-
-
Notifications
You must be signed in to change notification settings - Fork 932
Refactor some code out of tile manager #6756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… move some methods around.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6756 +/- ##
==========================================
+ Coverage 92.23% 92.40% +0.17%
==========================================
Files 285 288 +3
Lines 23735 23771 +36
Branches 5043 5054 +11
==========================================
+ Hits 21891 21965 +74
+ Misses 1844 1806 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wayofthefuture
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a good read, but can't really get into testing it as I'm out of town. Will have more time starting Wednesday. Looks good to me though... I added some slight suggestions...
|
I accidentally deleted your comment about tests fyi! |
…ogic, and wrap jump handling.
…add tests for this behavior.
|
Ok, I've added tests to sorting, added some checks to backfill flag to avoid doing it twice when there's no need, and added tests for that. |
This introduces the
InViewTilesclass that stores all the tiles that are currently loaded in view.It moves some of the logic related to these tiles to this class.
It moves the raster fade logic into another file (not a class, but just a method at this point).
It moves some methods and for loops around to better places than what they used to be.
This PR doesn't change any internal logic as far as I could see.
This is related to other PRs in this area, in order to improve the code in Tile Manager.
I couldn't find a lot of code related to vector handling that is worth a
tile_manager_vector.tsfile, but I might have overlooked.Launch Checklist
CHANGELOG.mdunder the## mainsection.