fix: addressed review comments

Author: marcj

packages/type-compiler/src/compiler.ts

@@ -2181,7 +2181,7 @@ export class ReflectionTransformer implements CustomTransformer {
             : isTypeReferenceNode(type)
                 ? type.typeName
                 : (isIdentifier(type.expression) ? type.expression : undefined);
-        const typeArguments: readonly TypeNode[] | undefined = isTypeReferenceNode(type) || isExpressionWithTypeArguments(type) ? type.typeArguments : [];
+        const typeArguments: readonly TypeNode[] | undefined = isTypeReferenceNode(type) || isExpressionWithTypeArguments(type) ? type.typeArguments : undefined;
 
         if (!typeName) {
             program.pushOp(ReflectionOp.any);

packages/type-spec/src/type.ts

@@ -35,6 +35,10 @@ export enum TypeNumberBrand {
     float64,
 }
 
+/**
+ * Intrinsic string manipulation type operations.
+ * These correspond to TypeScript's built-in string manipulation utility types.
+ */
 export enum TypeIntrinsic {
     Uppercase,
     Lowercase,

packages/type/src/reflection/processor.ts

@@ -1207,6 +1207,10 @@ export class Processor {
                                     this.push(handleUncapitalize(type));
                                     break;
                                 }
+                                default: {
+                                    this.push(type);
+                                    break;
+                                }
                             }
                             break;
                         }
@@ -1797,6 +1801,7 @@ function handleUppercase(type: Type): Type {
     if (type.kind !== ReflectionKind.literal || 'string' !== typeof type.literal) {
         return { kind: ReflectionKind.string };
     }
+    if (!type.literal) return type;
     return { kind: ReflectionKind.literal, literal: type.literal.toUpperCase() };
 }
 
@@ -1807,6 +1812,7 @@ function handleLowercase(type: Type): Type {
     if (type.kind !== ReflectionKind.literal || 'string' !== typeof type.literal) {
         return { kind: ReflectionKind.string };
     }
+    if (!type.literal) return type;
     return { kind: ReflectionKind.literal, literal: type.literal.toLowerCase() };
 }
 
@@ -1817,6 +1823,7 @@ function handleCapitalize(type: Type): Type {
     if (type.kind !== ReflectionKind.literal || 'string' !== typeof type.literal) {
         return { kind: ReflectionKind.string };
     }
+    if (!type.literal) return type;
     return { kind: ReflectionKind.literal, literal: type.literal.charAt(0).toUpperCase() + type.literal.slice(1) };
 }
 
@@ -1827,6 +1834,7 @@ function handleUncapitalize(type: Type): Type {
     if (type.kind !== ReflectionKind.literal || 'string' !== typeof type.literal) {
         return { kind: ReflectionKind.string };
     }
+    if (!type.literal) return type;
     return { kind: ReflectionKind.literal, literal: type.literal.charAt(0).toLowerCase() + type.literal.slice(1) };
 }
 

packages/type/src/reflection/type.ts

@@ -2523,7 +2523,6 @@ export function stringifyType(type: Type, stateIn: Partial<StringifyTypeOptions>
                     break;
                 case ReflectionKind.templateLiteral:
                     stack.push({ before: '`' });
-                    debugger;
                     for (let i = type.types.length - 1; i >= 0; i--) {
                         const sub = type.types[i];
                         if (sub.kind === ReflectionKind.literal) {