Now that we have our codebase passing the linter with parser-no-errors: true 🎊 , we are running into parser errors not caught by the linter (marcoroth/herb#1251).
As Herb adds errors to the rendered page output but does not raise (from what I can tell), we are getting missing selector failures (such as Minitest::Assertion:expected to find visible css). When I go to debug the test, I believe my only mechanism for finding the failure is to read the rendered page output, which is onerous.
Perhaps we should raise when Rails.env.test?
Now that we have our codebase passing the linter with
parser-no-errors: true🎊 , we are running into parser errors not caught by the linter (marcoroth/herb#1251).As Herb adds errors to the rendered page output but does not raise (from what I can tell), we are getting missing selector failures (such as
Minitest::Assertion:expected to find visible css). When I go to debug the test, I believe my only mechanism for finding the failure is to read the rendered page output, which is onerous.Perhaps we should raise when Rails.env.test?