Refactor connection types to be used across application. (#1095)

* changelog

* Fixup

* lint

Author: Half-Shot

changelog.d/1095.bugfix

@@ -0,0 +1 @@
+Fix a case where outbound webhooks would not work if you had not enabled openproject (due to a mixed up config check).

src/Connections/GenericHook.ts

@@ -243,7 +243,7 @@ export class GenericHookConnection
     event: StateEvent<Record<string, unknown>>,
     { as, intent, config, messageClient, storage }: InstantiateConnectionOpts,
   ) {
-    if (!config.generic?.outbound) {
+    if (!config.generic?.enabled) {
       throw Error("Generic webhooks are not configured");
     }
     // Generic hooks store the hookId in the account data
@@ -294,7 +294,7 @@ export class GenericHookConnection
     data: Partial<Record<keyof GenericHookConnectionState, unknown>> = {},
     { as, intent, config, messageClient, storage }: ProvisionConnectionOpts,
   ) {
-    if (!config.generic) {
+    if (!config.generic?.enabled) {
       throw Error("Generic Webhooks are not configured");
     }
     const hookId = randomUUID();

tests/config/config.ts

@@ -3,6 +3,12 @@ import { DefaultConfigRoot } from "../../src/config/Defaults";
 import { expect } from "chai";
 import { ConnectionType } from "../../src/Connections/type";
 
+const minimalConfig = {
+  bridge: DefaultConfigRoot.bridge,
+  logging: DefaultConfigRoot.logging,
+  passFile: DefaultConfigRoot.passFile,
+};
+
 describe("Config/BridgeConfig", () => {
   describe("will handle the legacy queue.monolitihc option", () => {
     it("with no parameters", () => {
@@ -101,17 +107,7 @@ describe("Config/BridgeConfig", () => {
     });
   });
 
-  /**
-  Jira = "jira",
-  OpenProject = "openproject",
-   */
-
   describe("publicConfig", () => {
-    const minimalConfig = {
-      bridge: DefaultConfigRoot.bridge,
-      logging: DefaultConfigRoot.logging,
-      passFile: DefaultConfigRoot.passFile,
-    };
     it("for ChallengeHound", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -121,6 +117,7 @@ describe("Config/BridgeConfig", () => {
         await config.getPublicConfigForService(ConnectionType.ChallengeHound),
       ).to.deep.equal({});
     });
+
     it("for Feeds", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -130,6 +127,7 @@ describe("Config/BridgeConfig", () => {
         await config.getPublicConfigForService(ConnectionType.Feeds),
       ).to.deep.equal({ pollIntervalSeconds: 150 });
     });
+
     it("for Figma", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -144,6 +142,7 @@ describe("Config/BridgeConfig", () => {
         await config.getPublicConfigForService(ConnectionType.Figma),
       ).to.deep.equal({});
     });
+
     it("for Generic (inbound)", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -165,6 +164,7 @@ describe("Config/BridgeConfig", () => {
         waitForComplete: undefined,
       });
     });
+
     it("for Generic (outbound)", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -181,6 +181,7 @@ describe("Config/BridgeConfig", () => {
         await config.getPublicConfigForService(ConnectionType.GenericOutbound),
       ).to.deep.equal({});
     });
+
     it("for Github", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -202,6 +203,7 @@ describe("Config/BridgeConfig", () => {
         newInstallationUrl: undefined,
       });
     });
+
     it("for Gitlab", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -223,6 +225,7 @@ describe("Config/BridgeConfig", () => {
         userIdPrefix: "_foobar_",
       });
     });
+
     it("for Jira", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,
@@ -236,6 +239,7 @@ describe("Config/BridgeConfig", () => {
         await config.getPublicConfigForService(ConnectionType.Jira),
       ).to.deep.equal({});
     });
+
     it("for OpenProject", async () => {
       const config = new BridgeConfig({
         ...minimalConfig,