Skip to content

Commit c8e8575

Browse files
authored
Replace dingbat icons with emojis (#1091)
This ensures that icons are displayed with colour on all matrix clients Signed-off-by: Matthias Ahouansou <[email protected]>
1 parent 6690036 commit c8e8575

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

changelog.d/1091.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Use emojis for all icons instead of dingbats, ensuring all clients render the icons in colour.

src/Connections/GithubRepo.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1274,7 +1274,7 @@ export class GitHubRepoConnection
12741274
`onIssueEdited ${this.roomId} ${this.org}/${this.repo} #${event.issue.number}`,
12751275
);
12761276
const orgRepoName = event.repository.full_name;
1277-
const icon = "✏";
1277+
const icon = "✏";
12781278
const content = emojify(
12791279
`${icon} **${event.sender.login}** edited issue [${orgRepoName}#${event.issue.number}](${event.issue.html_url}): "${emojify(event.issue.title)}"`,
12801280
);
@@ -1563,7 +1563,7 @@ export class GitHubRepoConnection
15631563
}
15641564
}
15651565

1566-
const icon = verb === "merged" ? "✳" : "⚫";
1566+
const icon = verb === "merged" ? "✳" : "⚫";
15671567
const content = emojify(
15681568
`${icon} **${event.sender.login}** ${verb} PR [${orgRepoName}#${event.pull_request.number}](${event.pull_request.html_url}): "${event.pull_request.title}"${withComment}`,
15691569
);
@@ -1684,7 +1684,7 @@ export class GitHubRepoConnection
16841684
`onWorkflowCompleted ${this.roomId} ${this.org}/${this.repo} '${workflowRun.id}'`,
16851685
);
16861686
const orgRepoName = event.repository.full_name;
1687-
const icon = "";
1687+
const icon = "";
16881688
const content = emojify(
16891689
`${icon} Workflow **${event.workflow.name}** [${WORKFLOW_CONCLUSION_TO_NOTICE[workflowRun.conclusion]}](${workflowRun.html_url}) for ${orgRepoName} on branch \`${workflowRun.head_branch}\``,
16901690
);

0 commit comments

Comments
 (0)