Commit 42c3f0f
authored
feat: Improve proving networks setup (#4563)
## What ❔
* Add `attempts` column for submitting validation results. Initially the
setup worked the way that validation results are being sent with
retries, but without any measuring of attempts - so they are being sent
until accepted. In some cases it gets the system stuck - like change of
contracts or some other issues. So this PR adds `attempts` and metrics
for reached max attempts(configurable) - for which we can configure
alert and react.
* Metrics `proven_batches` and `acknowledged_batches` were reworked, so
they emit the latest proven/acknowledged batch instead of total amount.
* `failed_to_send_txs` metric was removed in favor of
`reached_max_attempts` metric.
* New metrics added:
- `submitter_address` - to track the address of the submitter in
Grafana, for easier accesibility
- `submitter_balance` - to track/set alerts on balance of submitter
- `contract_address` - address of proof manager contract - to be able to
track the contract's state from Grafana
* Crypto dependencies bumped - fixes the issue with verifier panicking
if receiving wrong proof. We don't want to crash the component in case
the submitted proof was incorrect
* Add filtering events by chain ID of current network - so we won't
receive proofs/events from other networks.
## Why ❔
This PR improves a few things in proving networks setup as preparation
to going in production.
## Is this a breaking change?
- [ ] Yes
- [ ] No
## Operational changes
<!-- Any config changes? Any new flags? Any changes to any scripts? -->
<!-- Please add anything that non-Matter Labs entities running their own
ZK Chain may need to know -->
## Checklist
<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->
- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.1 parent 0c35b20 commit 42c3f0f
File tree
19 files changed
+333
-192
lines changed- core
- lib/dal
- .sqlx
- migrations
- src
- node/eth_proof_manager/src
- sender
- watcher
- events
- prover
19 files changed
+333
-192
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
258 | 258 | | |
259 | | - | |
| 259 | + | |
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
266 | | - | |
| 266 | + | |
267 | 267 | | |
268 | | - | |
269 | | - | |
| 268 | + | |
| 269 | + | |
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| |||
Lines changed: 22 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 31 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments