Merge pull request The-OpenROAD-Project#7470 from gadfort/pdn-markers

pdn: add marker category for repair channels

Author: maliberty

src/pdn/src/connect.cpp

@@ -920,6 +920,8 @@ void Connect::recordFailedVias() const
     tool_category = odb::dbMarkerCategory::create(grid_->getBlock(), "PDN");
     tool_category->setSource("PDN");
   }
+  odb::dbMarkerCategory* via_category
+      = odb::dbMarkerCategory::createOrGet(tool_category, "Via");
 
   for (const auto& [reason, shapes] : failed_vias_) {
     std::string reason_str;
@@ -937,8 +939,8 @@ void Connect::recordFailedVias() const
         reason_str = "Ripup";
         break;
       case failedViaReason::RECHECK:
-        reason_str = "Recheck";
-        break;
+        // Do not report recheck vias
+        continue;
       case failedViaReason::OTHER:
         reason_str = "Other";
         break;
@@ -948,7 +950,7 @@ void Connect::recordFailedVias() const
     reason_str += " - " + layer0_->getName() + " -> " + layer1_->getName();
 
     odb::dbMarkerCategory* category
-        = odb::dbMarkerCategory::createOrGet(tool_category, reason_str.c_str());
+        = odb::dbMarkerCategory::createOrGet(via_category, reason_str.c_str());
 
     for (const auto& [net, shape] : shapes) {
       odb::dbMarker* marker = odb::dbMarker::create(category);

src/pdn/src/straps.cpp

@@ -2361,6 +2361,14 @@ void RepairChannelStraps::repairGridChannels(
   } else {
     const auto remaining_channels = findRepairChannels(grid);
     if (!remaining_channels.empty()) {
+      odb::dbMarkerCategory* tool_category
+          = grid->getBlock()->findMarkerCategory("PDN");
+      if (tool_category == nullptr) {
+        tool_category = odb::dbMarkerCategory::create(grid->getBlock(), "PDN");
+        tool_category->setSource("PDN");
+      }
+      odb::dbMarkerCategory* category = odb::dbMarkerCategory::createOrReplace(
+          tool_category, "Repair channels");
       // if channels remain, report them and generate error
       const double dbu_to_microns = grid->getBlock()->getDbUnitsPerMicron();
       for (const auto& channel : remaining_channels) {
@@ -2378,6 +2386,15 @@ void RepairChannelStraps::repairGridChannels(
             Shape::getRectText(channel.area, dbu_to_microns),
             channel.connect_to->getName(),
             nets);
+
+        odb::dbMarker* marker = odb::dbMarker::create(category);
+        if (marker == nullptr) {
+          continue;
+        }
+        marker->addShape(channel.area);
+        for (auto* net : channel.nets) {
+          marker->addSource(net);
+        }
       }
       if (!allow) {
         grid->getLogger()->error(