Merge pull request The-OpenROAD-Project#6602 from eder-matheus/coverity_fixes

coverity fixes

Author: maliberty

src/cts/include/cts/TritonCTS.h

@@ -227,12 +227,12 @@ class TritonCTS
                                  int locX,
                                  int locY);
 
-  sta::dbSta* openSta_;
-  sta::dbNetwork* network_;
-  Logger* logger_;
-  CtsOptions* options_;
+  sta::dbSta* openSta_ = nullptr;
+  sta::dbNetwork* network_ = nullptr;
+  Logger* logger_ = nullptr;
+  CtsOptions* options_ = nullptr;
   std::unique_ptr<TechChar> techChar_;
-  rsz::Resizer* resizer_;
+  rsz::Resizer* resizer_ = nullptr;
   std::vector<std::unique_ptr<TreeBuilder>> builders_;
   std::set<odb::dbNet*> staClockNets_;
   std::set<odb::dbNet*> visitedClockNets_;

src/cts/src/TechChar.cpp

@@ -1628,6 +1628,11 @@ void TechChar::create()
                  masterNames_.size(), solution.instVector.size(),
                  buffersUpdate, topologiesCreated);
       // clang-format on
+
+      if (buffersUpdate == 0) {
+        continue;
+      }
+
       do {
         // For each possible load.
         for (float load : loadsToTest_) {

src/cts/src/TritonCTS.cpp

@@ -1150,7 +1150,7 @@ TreeBuilder* TritonCTS::initClockTreeForMacrosAndRegs(
                       "registers");
   if (secondBuilder) {
     secondBuilder->setTreeType(TreeType::RegisterTree);
-    secondBuilder->setTopBufferName(topBufferName);
+    secondBuilder->setTopBufferName(std::move(topBufferName));
     secondBuilder->setDrivingNet(firstNet);
     secondBuilder->setTopInputNet(clkInputNet);
   }

src/drt/src/frRegionQuery.h

@@ -143,7 +143,6 @@ class frRegionQuery
  private:
   struct Impl;
   std::unique_ptr<Impl> impl_;
-  bool verbose_;
 
   frRegionQuery();
   std::vector<std::pair<frBlockObject*, Rect>> getVias(frLayerNum layer_num);

src/drt/src/rp/FlexRP_prep.cpp

@@ -1459,9 +1459,9 @@ void FlexRP::prep_via2viaForbiddenLen_cutSpc(const frLayerNum& lNum,
 
   // same layer (use samenet rule if exist, otherwise use diffnet rule)
   if (viaDef1->getCutLayerNum() == viaDef2->getCutLayerNum()) {
-    const auto samenetCons
+    const auto& samenetCons
         = tech_->getLayer(viaDef1->getCutLayerNum())->getCutSpacing(true);
-    const auto diffnetCons
+    const auto& diffnetCons
         = tech_->getLayer(viaDef1->getCutLayerNum())->getCutSpacing(false);
     if (!samenetCons.empty()) {
       // check samenet spacing rule if exists

src/grt/src/RepairAntennas.cpp

@@ -66,6 +66,7 @@ RepairAntennas::RepairAntennas(GlobalRouter* grouter,
       logger_(logger),
       unique_diode_index_(1),
       illegal_diode_placement_count_(0),
+      has_new_violations_(false),
       routing_source_(RoutingSource::None)
 {
   block_ = db_->getChip()->getBlock();

src/grt/src/fastroute/include/DataType.h

@@ -167,8 +167,8 @@ struct TreeNode
   // heights and eID arrays size were increased after using PD
   // to create the tree topologies.
   static constexpr int max_connections = 10;
-  int16_t heights[max_connections];
-  int eID[max_connections];
+  int16_t heights[max_connections] = {0};
+  int eID[max_connections] = {0};
 
   int16_t x, y;  // position in the grid graph
   int nbr_count = 0;

src/ppl/src/IOPlacer.cpp

@@ -2742,11 +2742,11 @@ void IOPlacer::initCore(const std::set<int>& hor_layer_idxs,
     min_area_y = hor_layer->getArea() * database_unit * database_unit;
     min_width_y = hor_layer->getWidth();
 
-    min_spacings_y[hor_layer_idx] = min_spacing_y;
-    init_tracks_y[hor_layer_idx] = init_track_y;
+    min_spacings_y[hor_layer_idx] = std::move(min_spacing_y);
+    init_tracks_y[hor_layer_idx] = std::move(init_track_y);
     min_areas_y[hor_layer_idx] = min_area_y;
     min_widths_y[hor_layer_idx] = min_width_y;
-    num_tracks_y[hor_layer_idx] = num_track_y;
+    num_tracks_y[hor_layer_idx] = std::move(num_track_y);
   }
 
   for (int ver_layer_idx : ver_layer_idxs) {
@@ -2768,11 +2768,11 @@ void IOPlacer::initCore(const std::set<int>& hor_layer_idxs,
     min_area_x = ver_layer->getArea() * database_unit * database_unit;
     min_width_x = ver_layer->getWidth();
 
-    min_spacings_x[ver_layer_idx] = min_spacing_x;
-    init_tracks_x[ver_layer_idx] = init_track_x;
+    min_spacings_x[ver_layer_idx] = std::move(min_spacing_x);
+    init_tracks_x[ver_layer_idx] = std::move(init_track_x);
     min_areas_x[ver_layer_idx] = min_area_x;
     min_widths_x[ver_layer_idx] = min_width_x;
-    num_tracks_x[ver_layer_idx] = num_track_x;
+    num_tracks_x[ver_layer_idx] = std::move(num_track_x);
   }
 
   *core_ = Core(boundary,