Merge pull request The-OpenROAD-Project#7247 from The-OpenROAD-Project-staging/odb-def-dup-net

odb: handle a duplicate net in read_def

Author: maliberty

src/odb/src/defin/definNet.cpp

@@ -76,6 +76,11 @@ void definNet::begin(const char* name)
 
   if (_cur_net == nullptr) {
     _cur_net = dbNet::create(_block, name);
+  } else if (!_skip_wires) {
+    dbWire* wire = _cur_net->getWire();
+    if (wire) {
+      dbWire::destroy(wire);
+    }
   }
 
   _non_default_rule = nullptr;

src/odb/test/BUILD

@@ -24,6 +24,7 @@ COMPULSORY_TESTS = [
     "bterm_hier_create",
     "check_routing_tracks",
     "create_sboxes",
+    "def_dup_net",
     "def_parser",
     "design_is_routed1",
     "design_is_routed2",

src/odb/test/CMakeLists.txt

@@ -5,6 +5,7 @@ or_integration_tests(
     bterm_hier_create
     check_routing_tracks
     create_sboxes
+    def_dup_net
     def_parser
     design_is_routed1
     design_is_routed2

src/odb/test/def_dup_net.def

@@ -0,0 +1,15 @@
+VERSION 5.8 ;
+DIVIDERCHAR "/" ;
+BUSBITCHARS "[]" ;
+DESIGN segfault ;
+NETS 2 ;
+    - a
+        + ROUTED
+        metal2
+            ( 0 0 ) ( 0 0 ) ;
+    - a
+        + ROUTED
+        metal2
+            ( 0 0 ) ( 0 0 ) ;
+END NETS
+END DESIGN

src/odb/test/def_dup_net.ok

@@ -0,0 +1,4 @@
+[INFO ODB-0227] LEF file: Nangate45/Nangate45.lef, created 22 layers, 27 vias, 135 library cells
+[INFO ODB-0128] Design: segfault
+[INFO ODB-0133]     Created 2 nets and 0 connections.
+pass

src/odb/test/def_dup_net.tcl

@@ -0,0 +1,7 @@
+source "helpers.tcl"
+
+read_lef "Nangate45/Nangate45.lef"
+read_def "def_dup_net.def"
+
+puts "pass"
+exit 0