[W1][Table][5900][Service Header] new OnAfterSetDefaultNoSeries event

[RadoArvay]

Why do you need this change?

We need to select and replace some posting number series based on another setup if it exists. So we need a similar event as they are on sales or purchase headers (OnAfterInitPostingNoSeries).
Please add the new event OnAfterSetDefaultNoSeries to table "Service Header".

Describe the request

    local procedure SetDefaultNoSeries()
    begin
        ...
        case "Document Type" of
            ...
        end;

+       OnAfterSetDefaultNoSeries(Rec, xRec);
    end;

+   [IntegrationEvent(false, false)]
+   local procedure OnAfterSetDefaultNoSeries(var ServiceHeader: Record "Service Header"; xServiceHeader: Record "Service Header")
+   begin
+   end;

Internal work item: AB#622678

[attilatoury]

Hi @RadoArvay,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• xRec Parameter Justification: The proposed event OnAfterSetDefaultNoSeries includes xServiceHeader (xRec) as a parameter. Using xRec in event parameters requires justification because its behavior depends on the calling context and can be unreliable. Please provide:
  1. How will xServiceHeader (xRec) be used by event subscribers?
  2. Why is the current record (ServiceHeader) insufficient for your scenario?
  3. Why are the previous values of the record specifically needed?
  4. Confirmation that you understand xRec behavior in this context (i.e., it contains the record values before the SetDefaultNoSeries procedure was called).

Please update the issue with the missing details. We'll automatically re-analyze once updated.

[RadoArvay]

There is no need for me to use xRec parameter. I have just tried to align the event to the similar ones in sales and purchase code. So if it is a problem, avoid it.

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add a new integration event OnAfterSetDefaultNoSeries in the SetDefaultNoSeries procedure of Table 5900 "Service Header", fired at the end of the procedure. The existing if IsHandled then exit; pattern must be refactored to if not IsHandled then begin...end; so the OnAfter event fires in all conditions.

Location in SetDefaultNoSeries procedure:

    local procedure SetDefaultNoSeries()
    var
        PostingNoSeries: Code[20];
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeSetDefaultNoSeries(Rec, xRec, IsHandled);
        if not IsHandled then begin
            GeneralLedgerSetup.GetRecordOnce();
            if GeneralLedgerSetup."Journal templ. Name Mandatory" then begin
                if "Journal Templ. Name" = '' then begin
                    if not IsCreditDocType() then
                        GenJournalTemplate.Get(ServiceMgtSetup."Serv. Inv. Template Name")
                    else
                        GenJournalTemplate.Get(ServiceMgtSetup."Serv. Cr. Memo Templ. Name");
                    "Journal Templ. Name" := GenJournalTemplate.Name;
                end else
                    GenJournalTemplate.Get("Journal Templ. Name");
                PostingNoSeries := GenJournalTemplate."Posting No. Series";
            end else
                if IsCreditDocType() then
                    PostingNoSeries := ServiceMgtSetup."Posted Serv. Credit Memo Nos."
                else
                    PostingNoSeries := ServiceMgtSetup."Posted Service Invoice Nos.";

            case "Document Type" of
                "Document Type"::Quote, "Document Type"::Order:
                    begin
                        if NoSeries.IsAutomatic(PostingNoSeries) then
                            "Posting No. Series" := PostingNoSeries;
                        if NoSeries.IsAutomatic(ServiceMgtSetup."Posted Service Shipment Nos.") then
                            "Shipping No. Series" := ServiceMgtSetup."Posted Service Shipment Nos.";
                    end;
                "Document Type"::Invoice:
                    begin
                        if ("No. Series" <> '') and (ServiceMgtSetup."Service Invoice Nos." = PostingNoSeries) then
                            "Posting No. Series" := "No. Series"
                        else
                            if NoSeries.IsAutomatic(PostingNoSeries) then
                                "Posting No. Series" := PostingNoSeries;
                        if ServiceMgtSetup."Shipment on Invoice" then
                            if NoSeries.IsAutomatic(ServiceMgtSetup."Posted Service Shipment Nos.") then
                                "Shipping No. Series" := ServiceMgtSetup."Posted Service Shipment Nos.";
                    end;
                "Document Type"::"Credit Memo":
                    if ("No. Series" <> '') and (ServiceMgtSetup."Service Credit Memo Nos." = PostingNoSeries) then
                        "Posting No. Series" := "No. Series"
                    else
                        if NoSeries.IsAutomatic(PostingNoSeries) then
                            "Posting No. Series" := PostingNoSeries;
            end;
        end;

        OnAfterSetDefaultNoSeries(Rec);  // <-- New event
    end;

Event Publisher (add at the end of the table with other events):

    [IntegrationEvent(false, false)]
    local procedure OnAfterSetDefaultNoSeries(var ServiceHeader: Record "Service Header")
    begin
    end;

---

File: ServiceHeader.Table.al