[DE] [Event Request] E-Documents for Germany - Export XRechnung - OnAfterFormatDecimal, OnAfterFormatFourDecimal

[pri-kise]

Why do you need this change?

ome recipients and downstream systems require a stable text representation for numeric amounts (for example, always two decimal places such as "58.00" instead of "58"). Although the current internal formatting may be formally correct, customers report interoperability issues.

Describe the request

    procedure FormatDecimal(VarDecimal: Decimal): Text[30]
    var
        FormattedValue: Text[30];
    begin
        //>Change
        //-exit(Format(Round(VarDecimal, 0.01), 0, 9));
        FormattedValue := Format(Round(VarDecimal, 0.01), 0, 9);
        OnAfterFormatDecimal(VarDecimal, FormattedValue);
        exit(FormattedValue);
        //>Change
    end;

    procedure FormatFourDecimal(VarDecimal: Decimal): Text[30]
    var
        FormattedValue: Text[30];
    begin
        //>Change
        //-exit(Format(Round(VarDecimal, 0.0001), 0, 9));
        FormattedValue := Format(Round(VarDecimal, 0.0001), 0, 9);
        OnAfterFormatFourDecimal(VarDecimal, FormattedValue);
        exit(FormattedValue);
        //>Change
    end;

    procedure FormatFiveDecimal(VarDecimal: Decimal): Text[30]
    var
        FormattedValue: Text[30];
    begin
        //>Change
        //-exit(Format(Round(VarDecimal, 0.00001), 0, 9));
        FormattedValue := Format(Round(VarDecimal, 0.00001), 0, 9);
        OnAfterFormatFiveDecimal(VarDecimal, FormattedValue);
        exit(FormattedValue);
        //>Change
    end;

[IntegrationEvent(false, false)]
local procedure OnAfterFormatDecimal(Value: Decimal; var FormattedValue: Text)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnAfterFormatFourDecimal(Value: Decimal; var FormattedValue: Text)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnAfterFormatFiveDecimal(Value: Decimal; var FormattedValue: Text)
begin
end;

Additional Information

If this issue is approved then I can add the events via Pull Request by myself.
Internal work item: AB#622436

[attilatoury]

✅ Analysis complete - approved for implementation

---

Implementation:

Add three integration events in the FormatDecimal, FormatFourDecimal, and FormatFiveDecimal procedures of Codeunit 13916 "Export XRechnung Document".

Procedures FormatDecimal, FormatFourDecimal, and FormatFiveDecimal:

    procedure FormatDecimal(VarDecimal: Decimal): Text[30]
    var
        FormattedValue: Text[30];
    begin
        FormattedValue := Format(Round(VarDecimal, 0.01), 0, 9);
        OnAfterFormatDecimal(VarDecimal, FormattedValue);
        exit(FormattedValue);
    end;

    procedure FormatFourDecimal(VarDecimal: Decimal): Text[30]
    var
        FormattedValue: Text[30];
    begin
        FormattedValue := Format(Round(VarDecimal, 0.0001), 0, 9);
        OnAfterFormatFourDecimal(VarDecimal, FormattedValue);
        exit(FormattedValue);
    end;

    procedure FormatFiveDecimal(VarDecimal: Decimal): Text[30]
    var
        FormattedValue: Text[30];
    begin
        FormattedValue := Format(Round(VarDecimal, 0.00001), 0, 9);
        OnAfterFormatFiveDecimal(VarDecimal, FormattedValue);
        exit(FormattedValue);
    end;

Event Publisher (add at the end of the codeunit with other events):

    [IntegrationEvent(false, false)]
    local procedure OnAfterFormatDecimal(Value: Decimal; var FormattedValue: Text)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterFormatFourDecimal(Value: Decimal; var FormattedValue: Text)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterFormatFiveDecimal(Value: Decimal; var FormattedValue: Text)
    begin
    end;

---

File: ExportXRechnungDocument.Codeunit.al

[miljance]

@pri-kise Why is this change needed? Those events alone are not enough. If you reformat the values, I see following challenges:

• You need to make sure that XML file is still valid
• You need to make sure that Totals add up
• You need to make sure that unit price*quantity is correct taking into account newly rounded values.
• The functions no longer do the simple job they are intended to do
• The generated XML file no longer reflects the actual data in the Sales Document. It feels like in this case I would rather setup the rounding for the sales documents somewhere rather than messing with XML file.

Do you have the actual requirement? While I would not be bothered with new Events it feels like opening a door to creating invalid XML files for your customers.