revert: "feat(container-loader): add optional connection retry timeout" #25814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: loader
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the retry connection timeout functionality from the ConnectionManager. The feature previously allowed specifying a maximum time to wait for successful connection attempts before giving up.
Key changes:
- Removed the
retryConnectionTimeoutMsparameter from the ConnectionManager and Container APIs - Removed timeout checking logic from the connection retry loop
- Removed three test cases that validated the timeout behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/loader/container-loader/src/test/connectionManager.spec.ts | Removed three test cases covering retry timeout scenarios (timeout exceeded, timeout not exceeded, and no timeout configured) |
| packages/loader/container-loader/src/container.ts | Removed retryConnectionTimeoutMs property from IContainerCreateProps interface and removed internal field _retryConnectionTimeoutMs from Container class |
| packages/loader/container-loader/src/connectionManager.ts | Removed retryConnectionTimeoutMs constructor parameter, removed initialConnectionStartTime tracking field, and removed timeout checking logic from the connection retry loop |
WillieHabi
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24948