[CmdPal] Removing App tag

[niels9001]

The "App" tag is pretty redundant and is adding a lot of visual noise. Closes #38968

New:

[moooyo]

Agree.

Another thing is, in top level page, only Apps result have app tags.

I think we also need to add tag for fallback item to distinguish their source?

[zadjii-msft]

Wait doesn't this also get rid of the top-level tag too? I thought we wanted that to make sure that we could clearly differentiate the app results from the command ones

[niels9001]

@moooyo @zadjii-msft Meh.. that's a good point. Is there a way to differentiate between the two?

Still, even on a toplevel, the default tag UX feels 'heavy' to just point something out as a tag.. Not for this PR, but maybe something to figure out longer term how make that more subtle

[zadjii-msft]

gah this is annoying. There's not an easy way to differentiate them - least not currently. The main page needs ListItems with tags. The Apps page doesn't. That basically necessitates having two different lists of ListItems, one with tags and one without.

seems like it'd be silly for us to be constructing new ListItem's as we're filtering the top-level. That should be the hottest, cleanest path

I suppose the cache could have them all be created with the tags, and then have AllAppsPage.GetItems iterate over the cache, and build new ListItems specific to that page, without the tags.

[Copilot]

Pull Request Overview

This PR removes the redundant "App" tag from application items in the CmdPal interface to reduce visual noise, as requested in issue #38968.

Key Changes

• Removed the static "App" tag definition and assignment from AppListItem
• Simplified the UI by eliminating unnecessary visual clutter

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The null-forgiving operator (!) is used on _app.Commands without validation. Consider adding a null check or using conditional access to prevent potential null reference exceptions.

Suggested change

	MoreCommands = _app.Commands!.ToArray();
	MoreCommands = (_app.Commands?.ToArray()) ?? Array.Empty<ICommand>();

[niels9001]

@zadjii-msft do we want to move forward with this PR?

[michaeljolley]

@niels9001, this just removes the tag altogether? I think that's fine.

I would clean up the merge but then my approval wouldn't count. 😄

[michaeljolley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[michaeljolley]

Eh... that merge erased your changes. 😨

[michaeljolley]

@niels9001, see above comment.

[niels9001]

Eh... that merge erased your changes. 😨

Lol. PMs gonna dev.

Repushed the changes - please take it for a spin so I didn't break anything!

[michaeljolley]

Alas, he did not repush the changes. Don't worry. I got you friend. 🤝

[michaeljolley]

Closing for #43439