[Light Switch] Enter latitude and longitude manually in Sunrise to sunset mode #43276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaylyn-Barbee
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niels9001
requested changes
Nov 5, 2025
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Jaylyn-Barbee
added
the
Don't merge - Hold for release
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Jaylyn-Barbee
removed
the
Don't merge - Hold for release
Contributor
yeelam-gordon
left a comment
yeelam-gordon
left a comment
There was a problem hiding this comment.
Review from Copilot
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml
Outdated
Show resolved
Hide resolved
src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml
Outdated
Show resolved
Hide resolved
src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Views/LightSwitchPage.xaml.cs
Outdated
Show resolved
Hide resolved
src/modules/LightSwitch/LightSwitchService/LightSwitchStateManager.cpp
Outdated
Show resolved
Hide resolved
…com/microsoft/PowerToys into feature/lightswitch-manual-location
zateutsch
reviewed
Nov 10, 2025
| { | ||
| double latVal = std::stod(lat); | ||
| double lonVal = std::stod(lon); | ||
| return !(latVal == 0 && lonVal == 0) && (latVal >= -90.0 && latVal <= 90.0) && (lonVal >= -180.0 && lonVal <= 180.0); |
There was a problem hiding this comment.
why can't latitude and longitude both be equal to zero? not sure this is a problem but struck me
Contributor
Author
There was a problem hiding this comment.
It's what we use as the defaults and it just prevents updates from happening when they aren't supposed to. Luckily, I don't think anyone lives here
Collaborator
There was a problem hiding this comment.
Can't we just have null as defaults?
niels9001
approved these changes
Nov 11, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vanzue
pushed a commit
that referenced
this pull request
Nov 13, 2025
…nset mode (#43276) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR introduces new UI to allow the users to manually enter their lat/long. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #42429 - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Localization:** All end-user-facing strings can be localized - [x] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #[5979](https://github.com/MicrosoftDocs/windows-dev-docs-pr/pull/5979) --------- Co-authored-by: Niels Laute <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR introduces new UI to allow the users to manually enter their lat/long.
PR Checklist