The CxPlatRef* routines expect a CXPLAT_REF_COUNT to always have at least 1 ref count. Use plain increment/decrement

Author: anrossi

src/core/registration.h

@@ -183,7 +183,7 @@ QuicRegistrationRundownAcquire(
         //
         // Only increment the detailed ref count if the Rundown acquire succeeded.
         //
-        CxPlatRefIncrement(&Registration->RefTypeCount[Ref]);
+        InterlockedIncrement64(&Registration->RefTypeCount[Ref]);
     }
 #else
     UNREFERENCED_PARAMETER(Ref);
@@ -204,7 +204,8 @@ QuicRegistrationRundownRelease(
     )
 {
 #if DEBUG
-    CxPlatRefDecrement(&Registration->RefTypeCount[Ref]);
+    InterlockedDecrement64(&Registration->RefTypeCount[Ref]);
+    CXPLAT_DBG_ASSERT(QuicReadLongPtrNoFence(&Registration->RefTypeCount[Ref]) >= 0);
 #else
     UNREFERENCED_PARAMETER(Ref);
 #endif

src/inc/quic_platform_posix.h

@@ -291,7 +291,9 @@ InterlockedDecrement64(
     return __sync_sub_and_fetch(Addend, (int64_t)1);
 }
 
-#define QuicReadPtrNoFence(p) ((void*)(*p)) // TODO
+#define QuicReadPtrNoFence(p) __atomic_load_n((p), __ATOMIC_RELAXED)
+
+#define QuicReadLongPtrNoFence(p) __atomic_load_n((p), __ATOMIC_RELAXED)
 
 //
 // Assertion interfaces.