Move special case to the callsite, from the ref count management calls

Author: anrossi

src/core/connection.h

@@ -1093,15 +1093,7 @@ QuicConnAddRef(
     UNREFERENCED_PARAMETER(Ref);
 #endif
 
-    if (!Connection->State.CleanupStarted) {
-        CxPlatRefIncrement(&Connection->RefCount);
-    } else {
-        //
-        // When the connection is in the cleanup state, the only caller allowed
-        // to touch it is a worker thread.
-        //
-        CXPLAT_DBG_ASSERT(Ref == QUIC_CONN_REF_WORKER);
-    }
+    CxPlatRefIncrement(&Connection->RefCount);
 }
 
 //
@@ -1142,6 +1134,13 @@ QuicConnRelease(
             CXPLAT_DBG_ASSERT(Connection->Worker != NULL);
             QuicWorkerQueueConnection(Connection->Worker, Connection);
         } else {
+            if (Connection->State.CleanupStarted) {
+                //
+                // When the connection is in the cleanup state, the only caller
+                // allowed to free it is a worker thread.
+                //
+                CXPLAT_DBG_ASSERT(Ref == QUIC_CONN_REF_WORKER);
+            }
             QuicConnFree(Connection);
         }
     }

src/core/worker.c

@@ -271,7 +271,19 @@ QuicWorkerQueueConnection(
             "[conn][%p] Scheduling: %u",
             Connection,
             QUIC_SCHEDULE_QUEUED);
-        QuicConnAddRef(Connection, QUIC_CONN_REF_WORKER);
+        if (Connection->State.CleanupStarted) {
+#if DEBUG
+            //
+            // If the Connection is in the CleanupStarted state, its ref count
+            // is zero and it is queued here for freeing.
+            // Only increment the detailed ref count in debug builds.
+            // Just don't increment the main ref count in this state.
+            //
+            CxPlatRefIncrement(&Connection->RefTypeBiasedCount[QUIC_CONN_REF_WORKER]);
+#endif
+        } else {
+            QuicConnAddRef(Connection, QUIC_CONN_REF_WORKER);
+        }
         CxPlatListInsertTail(&Worker->Connections, &Connection->WorkerLink);
         ConnectionQueued = TRUE;
     }