Remove volatile access to this flag

Author: anrossi

src/core/connection.h

@@ -1113,10 +1113,8 @@ QuicConnRelease(
     QuicConnValidate(Connection);
 
     BOOLEAN LastRef = FALSE;
-    QUIC_CONNECTION_STATE State = {0};
-    State.Flags = CxPlatReadNoFence64((volatile const int64_t*)&Connection->State.Flags);
 
-    if (!State.CleanupStarted) {
+    if (!Connection->State.CleanupStarted) {
         LastRef = CxPlatRefDecrement(&Connection->RefCount);
 #if DEBUG
         CXPLAT_TEL_ASSERT(!CxPlatRefDecrement(&Connection->RefTypeBiasedCount[Ref]));
@@ -1145,8 +1143,7 @@ QuicConnRelease(
             // datapath binding being deleted on a callback. Instead, queue the
             // connection to be released by the worker.
             //
-            State.CleanupStarted = TRUE;
-            CxPlatWriteNoFence64((volatile int64_t*)&Connection->State.Flags, State.Flags);
+            Connection->State.CleanupStarted = TRUE;
             CXPLAT_DBG_ASSERT(Connection->Worker != NULL);
             QuicWorkerQueueConnection(Connection->Worker, Connection);
         } else {

src/inc/quic_platform_posix.h

@@ -295,10 +295,6 @@ InterlockedDecrement64(
 
 #define QuicReadLongPtrNoFence(p) __atomic_load_n((p), __ATOMIC_RELAXED)
 
-#define CxPlatReadNoFence64(p) __atomic_load_n((p), __ATOMIC_RELAXED)
-
-#define CxPlatWriteNoFence64(p, v) __atomic_store_n((p), (v), __ATOMIC_RELAXED)
-
 //
 // Assertion interfaces.
 //

src/inc/quic_platform_winkernel.h

@@ -382,15 +382,11 @@ typedef EX_SPIN_LOCK CXPLAT_DISPATCH_RW_LOCK;
 #define QuicDecrementLongPtrRelease InterlockedDecrementRelease64
 #define QuicCompareExchangeLongPtrNoFence InterlockedCompareExchangeNoFence64
 #define QuicReadLongPtrNoFence ReadNoFence64
-#define CxPlatReadNoFence64 ReadNoFence64
-#define CxPlatWriteNoFence64 WriteNoFence64
 #else
 #define QuicIncrementLongPtrNoFence InterlockedIncrementNoFence
 #define QuicDecrementLongPtrRelease InterlockedDecrementRelease
 #define QuicCompareExchangeLongPtrNoFence InterlockedCompareExchangeNoFence
 #define QuicReadLongPtrNoFence ReadNoFence
-#define CxPlatReadNoFence64 ReadNoFence64
-#define CxPlatWriteNoFence64 WriteNoFence64
 #endif
 #define QuicReadPtrNoFence ReadPointerNoFence
 

src/inc/quic_platform_winuser.h

@@ -559,12 +559,8 @@ typedef SRWLOCK CXPLAT_DISPATCH_RW_LOCK;
 
 #ifdef QUIC_RESTRICTED_BUILD
 #define QuicReadLongPtrNoFence(p) ((LONG64)(*p))
-#define CxPlatReadNoFence64(p) ((uint64_t)(*p))
-#define CxPlatWriteNoFence64(p, v) (*(p) = (v))
 #else
 #define QuicReadLongPtrNoFence ReadNoFence64
-#define CxPlatReadNoFence64 ReadNoFence64
-#define CxPlatWriteNoFence64 WriteNoFence64
 #endif
 
 #else
@@ -575,12 +571,8 @@ typedef SRWLOCK CXPLAT_DISPATCH_RW_LOCK;
 
 #ifdef QUIC_RESTRICTED_BUILD
 #define QuicReadLongPtrNoFence(p) ((LONG)(*p))
-#define CxPlatReadNoFence64(p) ((uint64_t)(*p))
-#define CxPlatWriteNoFence64(p, v) (*(p) = (v))
 #else
 #define QuicReadLongPtrNoFence ReadNoFence
-#define CxPlatReadNoFence64 ReadNoFence64
-#define CxPlatWriteNoFence64 WriteNoFence64
 #endif
 
 #endif