-
Notifications
You must be signed in to change notification settings - Fork 612
Add windows-2025 GitHub runner support for builds and tests #5325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: guhetier <[email protected]>
|
Do not change occurences of "windows-latest". Only add "windows-2025" when "windows-2022" is used and windows-2019 was used before support was removed. |
|
@copilot address all comments on the PR |
Co-authored-by: guhetier <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5325 +/- ##
==========================================
- Coverage 86.58% 85.50% -1.08%
==========================================
Files 59 59
Lines 18331 18621 +290
==========================================
+ Hits 15872 15922 +50
- Misses 2459 2699 +240 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds comprehensive support for GitHub's new
windows-2025runners across the MSQuic CI/CD pipeline, enabling builds and tests to run on the latest Windows environment.Overview
GitHub recently introduced
windows-2025runner images, and this change updates our workflows to utilize these new runners while maintaining backward compatibility with existingwindows-2022runners.Changes Made
Build Workflows:
build.ymlto includewindows-2025in the build matrix alongsidewindows-2022for both regular and official buildsstress.ymlwithwindows-2025configurations for stress testing builds and executiondotnet-test.ymlsupport for .NET interop testing onwindows-2025Workflows Preserved with
windows-latest:Following the principle of only adding
windows-2025wherewindows-2022was explicitly used (andwindows-2019was previously supported), the following workflows remain unchanged withwindows-latest:cargo.yml- Rust/Cargo builds continue usingwindows-latestcheck-clog.yml- CLOG validation remains onwindows-latestcheck-dotnet.yml- .NET validation remains onwindows-latestnetperf.yml- Performance testing continues usingwindows-latestplugins.yml- Plugin builds for WinDbg extensions and QuicTrace remain onwindows-latestwan-perf.yml- WAN performance testing continues usingwindows-latestTechnical Approach
The implementation adds
windows-2025as additional matrix options rather than replacingwindows-2022, ensuring:windows-2022) are updated, while workflows usingwindows-latestremain unchanged to track GitHub's defaultExceptions
Some workflows intentionally remain on
windows-2022:windows-2025doesn't currently support kernel driver developmentValidation
All modified YAML workflow files have been validated for syntax correctness, and the changes maintain full backward compatibility while extending support to the new runner environment.
Fixes #5242.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.