Add strong partitioning to listeners, connections, and streams #5376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5376 +/- ##
==========================================
- Coverage 86.77% 84.77% -2.00%
==========================================
Files 59 59
Lines 18328 18600 +272
==========================================
- Hits 15904 15769 -135
- Misses 2424 2831 +407 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guhetier
reviewed
Aug 25, 2025
mtfriesen
force-pushed
the
mtfriesen/partition_affinity
branch
from
98bb7fe to
06b3fc7
Compare
anrossi
reviewed
Sep 3, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anrossi
reviewed
Sep 4, 2025
anrossi
approved these changes
Sep 4, 2025
Copilot AI
pushed a commit
that referenced
this pull request
Oct 10, 2025
* WIP - listener affinity * WIP - listener events are onto partition thread * make connections explicitly partitioned, too * fix winuser build * update the sidecar, again * try to fix thread id abstraction * add array bounds assert * fix winkernel build (finally?) * update rust bindings * fix dotnet, too * fix more rust * fix a few bugs * WIP - test * add more tests, which all fail * sync submodules * WIP * add docs * WIP - tests passing w/o partition option * WIP - listener use-after-free on close notification * WIP - partition test (WIP) passes * WIP - more precise tests * test variable numbers of ecs * finalize basic test coverage * fix non-linux test build * more rust * fix release build * fix dotnet * updating sidecar * codecheck * fix winkernel build * try again to fix winkernel * STILL fix winkernel * fix winkernel yet again * fix win official * RE-fix * fix one listener bug * more listener fixes * more rust gen * more fixes * properly disable the feature on iouring/linux_xdp * ensure connections aren't implicitly partitioned * remove flaky/fragile/wrong stateless retry test * WIP * more fixes * improve comment * fix sidecar * initialize event for compiler * fix unref'd param * make connection async close wait opt-in * rename listener refcounts for clarity * add connection close async param * fixes * official build fix * dotnet * update spinquic for conn close async param * address PR feedback * do todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Resolves #5372
Adds a new (preview) listener parameter
QUIC_PARAM_LISTENER_PARTITION_INDEXto affinitize all event indications onto that partition and affinitizes all related object (connections, and by transitivity, streams) to that same partition. There is already a preview feature for client connections,ConnectionOpenInPartition. This is currently only supported end-to-end on linux with epoll, though much of the churn is cross-platform.This feature is primarily useful when operating in external execution context modes: it allows fine-grained control over where MsQuic processes all activity for a listener.
I found quite a few issues with the existing (preview) external execution context mode, which I tried to fix independently in #5384, but that fix was incomplete. I eventually had to add an asynchronous
RegistrationClose2API, else it was impossible to close and unload the registration, execution context, and MsQuic.Testing
Do any existing tests cover this change? Are new tests needed?
Added basic functional testing for the existing (preview) execution context feature, as well as targeted functional tests for partition affinity of listeners and connections. Streams are already implicitly aligned to connections and were not tested.
Documentation
Is there any documentation impact for this change?
All of these features are in preview; documentation was updated and improved.