-
Notifications
You must be signed in to change notification settings - Fork 279
Open
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunities
Description
Environment details
- OS: Linux (various Fedora and openSUSE)
- node-pty version: 1.1.0-beta21 (as shipped in vscode)
- node.js version: Electron 30.x with ELECTRON_RUN_AS_NODE
Issue description
18 passing (13s)
1 failing
1) UnixTerminal
signals in parent and child
SIGINT - custom in parent and child:
Uncaught AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
false !== true
+ expected - actual
-false
+true
at ChildProcess.<anonymous> (lib/unixTerminal.test.js:171:28)
at ChildProcess.emit (node:events:519:28)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5)
We've observed this test occasionally failing on aarch64, arm and riscv64, but never on x86_64. (This is possibly due to our x86_64 machines being fast)
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunities