make FilterClause constructor protected to address CA1012 warning

alzarei · alzarei · commit 7d39c882c964 · 2025-11-19T04:52:10.000-08:00
diff --git a/dotnet/src/VectorData/VectorData.Abstractions/FilterClauses/FilterClause.cs b/dotnet/src/VectorData/VectorData.Abstractions/FilterClauses/FilterClause.cs
@@ -14,7 +14,7 @@ public abstract class FilterClause
     /// <summary>
     /// Initializes a new instance of the <see cref="FilterClause"/> class.
     /// </summary>
-    public FilterClause()
+    protected FilterClause()
     {
     }
 }
diff --git a/dotnet/src/VectorData/VectorData.Abstractions/VectorData.Abstractions.csproj b/dotnet/src/VectorData/VectorData.Abstractions/VectorData.Abstractions.csproj
@@ -7,8 +7,6 @@
     <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</IsAotCompatible>
     <!-- temporarily disabled due to mysterious build issue -->
     <EnablePackageValidation>false</EnablePackageValidation>
-    <!-- Suppress CA1012: FilterClause constructor made public to allow Plugins.Web to inherit -->
-    <NoWarn>$(NoWarn);CA1012</NoWarn>
   </PropertyGroup>
 
   <Import Project="$(RepoRoot)/dotnet/nuget/nuget-package.props" />

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public abstract class FilterClause`
`14`	`14`	`/// <summary>`
`15`	`15`	`/// Initializes a new instance of the <see cref="FilterClause"/> class.`
`16`	`16`	`/// </summary>`
`17`		`- public FilterClause()`
	`17`	`+ protected FilterClause()`
`18`	`18`	`{`
`19`	`19`	`}`
`20`	`20`	`}`