Commit a689b0c
committed
refactor: Make SearchQueryFilterClause public (revert internal approach)
Reverting the internal + InternalsVisibleTo approach per reviewer feedback.
Making SearchQueryFilterClause public is the cleanest solution:
- Legitimate, reusable abstraction for text search scenarios
- Respects FilterClause architecture (stays in VectorData.Abstractions)
- No InternalsVisibleTo complexity or CS0436 warnings
- Precedent: Other FilterClause types are public (EqualToFilterClause, etc.)
- Other search connectors can benefit from this pattern
Trade-off: Adds one class to VectorData.Abstractions public API surface,
but it's a well-scoped, documented filter clause pattern with clear use cases.
Addresses reviewer question about SearchQueryFilterClause visibility.1 parent a3113a9 commit a689b0c
File tree
2 files changed
+1
-5
lines changed- dotnet/src/VectorData/VectorData.Abstractions
- FilterClauses
2 files changed
+1
-5
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | 39 | | |
44 | 40 | | |
45 | 41 | | |
| |||
0 commit comments