Skip to content

Commit a689b0c

Browse files
committed
refactor: Make SearchQueryFilterClause public (revert internal approach)
Reverting the internal + InternalsVisibleTo approach per reviewer feedback. Making SearchQueryFilterClause public is the cleanest solution: - Legitimate, reusable abstraction for text search scenarios - Respects FilterClause architecture (stays in VectorData.Abstractions) - No InternalsVisibleTo complexity or CS0436 warnings - Precedent: Other FilterClause types are public (EqualToFilterClause, etc.) - Other search connectors can benefit from this pattern Trade-off: Adds one class to VectorData.Abstractions public API surface, but it's a well-scoped, documented filter clause pattern with clear use cases. Addresses reviewer question about SearchQueryFilterClause visibility.
1 parent a3113a9 commit a689b0c

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

dotnet/src/VectorData/VectorData.Abstractions/FilterClauses/SearchQueryFilterClause.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace Microsoft.Extensions.VectorData;
1818
///
1919
/// See ADR-TextSearch-Contains-Support.md for architectural context and cross-engine comparison.
2020
/// </remarks>
21-
internal sealed class SearchQueryFilterClause : FilterClause
21+
public sealed class SearchQueryFilterClause : FilterClause
2222
{
2323
/// <summary>
2424
/// Initializes a new instance of the <see cref="SearchQueryFilterClause"/> class.

dotnet/src/VectorData/VectorData.Abstractions/VectorData.Abstractions.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ Microsoft.Extensions.VectorData.IVectorStoreRecordCollection&lt;TKey, TRecord&gt
3636
<PackageReference Include="Microsoft.Extensions.AI.Abstractions" />
3737
</ItemGroup>
3838

39-
<ItemGroup>
40-
<InternalsVisibleTo Include="Microsoft.SemanticKernel.Plugins.Web" />
41-
</ItemGroup>
42-
4339
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' Or '$(TargetFramework)' == 'net462' ">
4440
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" />
4541
<PackageReference Include="System.Text.Json" />

0 commit comments

Comments
 (0)