.NET: Implement Option 3 dual interface for Issue #10456

Add ITextSearch<TRecord> generic interface with LINQ filtering while maintaining
existing ITextSearch non-generic interface for backward compatibility.

## Background: Architectural Decision (Issue #10456)

Three options considered:

Option 1 (Native LINQ): Replace TextSearchFilter with Expression<Func<T, bool>>
- Breaking change: requires user migration
- Best long-term architecture

Option 2 (Translation Layer): Convert TextSearchFilter to LINQ internally
- Breaking change: RequiresDynamicCode propagates through API surface
- Reflection overhead, AOT incompatible

Option 3 (Dual Interface): Add ITextSearch<TRecord> alongside ITextSearch
- No breaking changes
- Maintains AOT compatibility
- Uses obsolete VectorSearchFilter in legacy path (temporary during transition)

## Implementation

### Generic Interface
- ITextSearch<TRecord> with 3 methods accepting TextSearchOptions<TRecord>
- TextSearchOptions<TRecord> with Expression<Func<TRecord, bool>>? Filter
- Explicit interface implementation in VectorStoreTextSearch<TRecord>

### Dual-Path Architecture
Two independent code paths, no translation layer:

Legacy path (non-generic):
- ITextSearch with TextSearchOptions and TextSearchFilter (clause-based)
- Uses VectorSearchOptions.OldFilter (obsolete) with pragma warning suppression
- No dynamic code, AOT compatible
- 10 existing tests unchanged

Modern path (generic):
- ITextSearch<TRecord> with TextSearchOptions<TRecord> and Expression filter
- Uses VectorSearchOptions.Filter (LINQ native, not obsolete)
- No dynamic code, AOT compatible
- 7 new tests

## Changes

- Added ITextSearch<TRecord> interface and TextSearchOptions<TRecord> class
- Implemented dual interface in VectorStoreTextSearch<TRecord>
- Deleted ~150 lines of Option 2 translation layer code
- Removed all RequiresDynamicCode attributes
- Removed DynamicallyAccessedMemberTypes.PublicMethods from 5 locations:
  - VectorStoreTextSearch.cs
  - TextSearchServiceCollectionExtensions.cs (3 methods)
  - TextSearchKernelBuilderExtensions.cs (1 method)
- Deleted 7 Option 2 translation tests
- Added 7 LINQ filtering tests
- Added DataModelWithTags to test base
- Reverted Program.cs to original state

## Files Changed

8 files, +144 insertions, -395 deletions

- ITextSearch.cs
- TextSearchOptions.cs (added generic class)
- VectorStoreTextSearch.cs (removed translation layer, added dual interface)
- TextSearchServiceCollectionExtensions.cs (removed PublicMethods annotation)
- TextSearchKernelBuilderExtensions.cs (removed PublicMethods annotation)
- VectorStoreTextSearchTestBase.cs (added DataModelWithTags)
- VectorStoreTextSearchTests.cs (removed 7 tests, added 7 tests)
- Program.cs in AotTests (removed suppression, restored tests)

Author: alzarei

dotnet/src/SemanticKernel.Abstractions/Data/TextSearch/ITextSearch.cs

@@ -8,6 +8,7 @@ namespace Microsoft.SemanticKernel.Data;
 
 /// <summary>
 /// Interface for text based search queries with type-safe LINQ filtering for use with Semantic Kernel prompts and automatic function calling.
+/// This generic interface supports LINQ-based filtering through <see cref="TextSearchOptions{TRecord}"/> for type-safe queries.
 /// </summary>
 /// <typeparam name="TRecord">The type of record being searched.</typeparam>
 [Experimental("SKEXP0001")]
@@ -19,10 +20,6 @@ public interface ITextSearch<TRecord>
     /// <param name="query">What to search for.</param>
     /// <param name="searchOptions">Options used when executing a text search.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
-    /// <remarks>
-    /// Dynamic code generation is only required when using AnyTagEqualTo filter operations that generate LINQ Contains expressions.
-    /// Simple equality filtering is AOT-compatible.
-    /// </remarks>
     Task<KernelSearchResults<string>> SearchAsync(
         string query,
         TextSearchOptions<TRecord>? searchOptions = null,
@@ -34,10 +31,6 @@ Task<KernelSearchResults<string>> SearchAsync(
     /// <param name="query">What to search for.</param>
     /// <param name="searchOptions">Options used when executing a text search.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
-    /// <remarks>
-    /// Dynamic code generation is only required when using AnyTagEqualTo filter operations that generate LINQ Contains expressions.
-    /// Simple equality filtering is AOT-compatible.
-    /// </remarks>
     Task<KernelSearchResults<TextSearchResult>> GetTextSearchResultsAsync(
         string query,
         TextSearchOptions<TRecord>? searchOptions = null,
@@ -49,10 +42,6 @@ Task<KernelSearchResults<TextSearchResult>> GetTextSearchResultsAsync(
     /// <param name="query">What to search for.</param>
     /// <param name="searchOptions">Options used when executing a text search.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
-    /// <remarks>
-    /// Dynamic code generation is only required when using AnyTagEqualTo filter operations that generate LINQ Contains expressions.
-    /// Simple equality filtering is AOT-compatible.
-    /// </remarks>
     Task<KernelSearchResults<object>> GetSearchResultsAsync(
         string query,
         TextSearchOptions<TRecord>? searchOptions = null,
@@ -61,6 +50,7 @@ Task<KernelSearchResults<object>> GetSearchResultsAsync(
 
 /// <summary>
 /// Interface for text based search queries for use with Semantic Kernel prompts and automatic function calling.
+/// This non-generic interface uses legacy <see cref="TextSearchFilter"/> for backward compatibility.
 /// </summary>
 public interface ITextSearch
 {

dotnet/src/SemanticKernel.AotTests/Program.cs

@@ -1,6 +1,5 @@
 // Copyright (c) Microsoft. All rights reserved.
 
-using System.Diagnostics.CodeAnalysis;
 using SemanticKernel.AotTests.UnitTests.Core.Functions;
 using SemanticKernel.AotTests.UnitTests.Core.Plugins;
 using SemanticKernel.AotTests.UnitTests.Search;
@@ -20,7 +19,6 @@ private static async Task<int> Main(string[] args)
         return success ? 1 : 0;
     }
 
-    [UnconditionalSuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.", Justification = "Test application intentionally tests dynamic code paths. VectorStoreTextSearch LINQ filtering requires reflection for dynamic expression building from runtime filter specifications.")]
     private static readonly Func<Task>[] s_unitTests =
     [
         // Tests for functions
@@ -59,7 +57,10 @@ private static async Task<int> Main(string[] args)
         KernelBuilderPluginsExtensionsTests.AddFromType,
         KernelBuilderPluginsExtensionsTests.AddFromObject,
 
-        // Tests for text search (VectorStoreTextSearch tests removed - incompatible with AOT due to RequiresDynamicCode for LINQ expressions)
+        // Tests for text search
+        VectorStoreTextSearchTests.GetTextSearchResultsAsync,
+        VectorStoreTextSearchTests.AddVectorStoreTextSearch,
+
         TextSearchExtensionsTests.CreateWithSearch,
         TextSearchExtensionsTests.CreateWithGetTextSearchResults,
         TextSearchExtensionsTests.CreateWithGetSearchResults,

dotnet/src/SemanticKernel.AotTests/UnitTests/Search/VectorStoreTextSearchTests.cs

@@ -1,6 +1,5 @@
 // Copyright (c) Microsoft. All rights reserved.
 
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.VectorData;
 using Microsoft.SemanticKernel;
@@ -11,7 +10,6 @@ namespace SemanticKernel.AotTests.UnitTests.Search;
 
 internal sealed class VectorStoreTextSearchTests
 {
-    [RequiresDynamicCode("Calls Microsoft.SemanticKernel.Data.VectorStoreTextSearch<TRecord>.GetTextSearchResultsAsync(String, TextSearchOptions, CancellationToken)")]
     public static async Task GetTextSearchResultsAsync()
     {
         // Arrange
@@ -39,7 +37,6 @@ public static async Task GetTextSearchResultsAsync()
         Assert.AreEqual("test-link", results[0].Link);
     }
 
-    [RequiresDynamicCode("Calls Microsoft.SemanticKernel.Data.VectorStoreTextSearch<TRecord>.GetTextSearchResultsAsync(String, TextSearchOptions, CancellationToken)")]
     public static async Task AddVectorStoreTextSearch()
     {
         // Arrange

dotnet/src/SemanticKernel.Core/Data/TextSearch/TextSearchKernelBuilderExtensions.cs

@@ -18,7 +18,7 @@ public static class TextSearchKernelBuilderExtensions
     /// <param name="resultMapper"><see cref="ITextSearchResultMapper" /> instance that can map a TRecord to a <see cref="TextSearchResult"/></param>
     /// <param name="options">Options used to construct an instance of <see cref="VectorStoreTextSearch{TRecord}"/></param>
     /// <param name="serviceId">An optional service id to use as the service key.</param>
-    public static IKernelBuilder AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicMethods)] TRecord>(
+    public static IKernelBuilder AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(
         this IKernelBuilder builder,
         ITextSearchStringMapper? stringMapper = null,
         ITextSearchResultMapper? resultMapper = null,

dotnet/src/SemanticKernel.Core/Data/TextSearch/TextSearchServiceCollectionExtensions.cs

@@ -22,7 +22,7 @@ public static class TextSearchServiceCollectionExtensions
     /// <param name="resultMapper"><see cref="ITextSearchResultMapper" /> instance that can map a TRecord to a <see cref="TextSearchResult"/></param>
     /// <param name="options">Options used to construct an instance of <see cref="VectorStoreTextSearch{TRecord}"/></param>
     /// <param name="serviceId">An optional service id to use as the service key.</param>
-    public static IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicMethods)] TRecord>(
+    public static IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(
         this IServiceCollection services,
         ITextSearchStringMapper? stringMapper = null,
         ITextSearchResultMapper? resultMapper = null,
@@ -58,7 +58,7 @@ public static class TextSearchServiceCollectionExtensions
     /// <param name="resultMapper"><see cref="ITextSearchResultMapper" /> instance that can map a TRecord to a <see cref="TextSearchResult"/></param>
     /// <param name="options">Options used to construct an instance of <see cref="VectorStoreTextSearch{TRecord}"/></param>
     /// <param name="serviceId">An optional service id to use as the service key.</param>
-    public static IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicMethods)] TRecord>(
+    public static IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(
         this IServiceCollection services,
         string vectorSearchableServiceId,
         ITextSearchStringMapper? stringMapper = null,
@@ -104,7 +104,7 @@ public static class TextSearchServiceCollectionExtensions
     /// <param name="options">Options used to construct an instance of <see cref="VectorStoreTextSearch{TRecord}"/></param>
     /// <param name="serviceId">An optional service id to use as the service key.</param>
     [Obsolete("Use the overload which doesn't accept a textEmbeddingGenerationServiceId, and configure an IEmbeddingGenerator instead with the collection represented by vectorSearchServiceId.")]
-    public static IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicMethods)] TRecord>(
+    public static IServiceCollection AddVectorStoreTextSearch<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] TRecord>(
         this IServiceCollection services,
         string vectorSearchServiceId,
         string textEmbeddingGenerationServiceId,