Skip to content

Cancellation Tokens not honored in SignIn flows #328

@rido-min

Description

@rido-min

SignIn(...) derives a local token from the optional cancellationToken, but the Bot Framework API calls in this method (e.g., Api.Users.Token.GetAsync, Api.Conversations.CreateAsync, Api.Bots.SignIn.GetResourceAsync) still use Context.Api’s internal cancellation token. If a caller passes a non-default token, it won’t cancel those requests; consider using an ApiClient instance constructed with token for all API calls in this method (or drop the parameter if it can’t be honored consistently).

Originally posted by @Copilot in #317 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions