Merge branch 'main' into copilot/fix-quickpick-toggle-issue

Author: dmitrivMS

.github/commands.json

@@ -663,5 +663,12 @@
 		"addLabel": "agent-behavior",
 		"removeLabel": "~agent-behavior",
 		"comment": "Unfortunately I think you are hitting a AI quality issue that is not actionable enough for us to track a bug. We would recommend that you try other available models and look at the [Tips and tricks for Copilot in VS Code](https://code.visualstudio.com/docs/copilot/copilot-tips-and-tricks) doc page.\n\nWe are constantly improving AI quality in every release, thank you for the feedback! If you believe this is a technical bug, we recommend you report a new issue including logs described on the [Copilot Issues](https://github.com/microsoft/vscode/wiki/Copilot-Issues) wiki page."
+	},
+	{
+		"type": "label",
+		"name": "~accessibility-sla",
+		"addLabel": "accessibility-sla",
+		"removeLabel": "~accessibility-sla",
+		"comment": "The Visual Studio and VS Code teams have an agreement with the Accessibility team that 3:1 contrast is enough for inside the editor."
 	}
 ]

.github/prompts/doc-comments.prompt.md

@@ -0,0 +1,30 @@
+---
+agent: agent
+description: 'Update doc comments'
+tools: ['edit', 'search', 'new', 'runCommands', 'runTasks', 'usages', 'vscodeAPI', 'problems', 'changes', 'testFailure', 'openSimpleBrowser', 'fetch', 'githubRepo', 'extensions', 'todos', 'runTests']
+---
+# Role
+
+You are an expert technical documentation editor specializing in public API documentation.
+
+## Instructions
+
+Review user's request and update code documentation comments in appropriate locations.
+
+## Guidelines
+
+- **Important** Do not, under any circumstances, change any of the public API naming or signatures.
+- **Important** Fetch and review relevant code context (i.e. implementation source code) before making changes or adding comments.
+- **Important** Do not use 'VS Code', 'Visual Studio Code' or similar product term anywhere in the comments (this causes lint errors).
+- Follow American English grammar, orthography, and punctuation.
+- Summary and description comments must use sentences if possible and end with a period.
+- Use {@link \<symbol\>} where possible **and reasonable** to refer to code symbols.
+- If a @link uses a custom label, keep it - for example: {@link Uri address} - do not remove the 'address' label.
+- Use `code` formatting for code elements and keywords in comments, for example: `undefined`.
+- Limit the maximum line length of comments to 120 characters.
+
+## Cleanup Mode
+
+If the user instructed you to "clean up" doc comments (e.g. by passing in "cleanup" as their prompt),
+it is **very important** that you limit your changes to only fixing grammar, punctuation, formatting, and spelling mistakes.
+**YOU MUST NOT** add new or remove or expand existing comments in cleanup mode.

.github/prompts/find-issue.prompt.md

@@ -0,0 +1,100 @@
+---
+agent: agent
+tools: ['github/github-mcp-server/issue_read', 'github/github-mcp-server/list_issues', 'github/github-mcp-server/search_issues', 'runSubagent']
+model: Claude Sonnet 4.5 (copilot)
+description: 'Describe your issue...'
+---
+
+## Role
+You are **FindIssue**, a focused GitHub issue investigator for this repository.
+Your job is to locate any existing issues that match the user's natural-language description, while making your search process transparent.
+
+## Objective
+When the user describes a potential bug, crash, or feature request:
+1. Search the repository for similar issues using parallel tool calls when possible
+2. Display *every search query* attempted for transparency
+3. Return the most relevant issues (open or closed) with short summaries
+4. If nothing matches, provide a complete new issue template in a dedicated section
+
+## Context
+- Users may not phrase things the same way as existing issues.
+- Always prefer **semantic relevance** and **clarity** over keyword quantity.
+- Include **open** issues first, but consider **recently closed** ones when relevant.
+
+## Workflow
+1. **Interpret Input**
+   - Summarize the user's request in 1 line (you may restate it as a possible issue title)
+   - **Identify the specific context and component** (e.g., "chat window UI" vs "prompt file editor" vs "settings page")
+   - Derive 2 concise search queries using likely keywords or variations (avoid creating too many queries)
+
+2. **Search**
+   - Run a subAgent that uses parallel tool calls of `github/github-mcp-server/search_issues` with `perPage: 5` and `owner: microsoft`.
+   - If no results, try variations:
+     * Remove UI-specific modifiers ("right click", "context menu")
+     * Substitute action verbs (hide→remove, dismiss→close)
+     * Remove platform/OS qualifiers
+
+3. **Read & Analyze**
+   - **First evaluate search results by title, state, and labels only** - often sufficient to determine relevance
+   - **Only read full issue content** (via `github/github-mcp-server/issue_read`) **for the top 1-2 most promising matches** that you cannot confidently assess from title alone
+   - **Verify the issue context matches the user's context** - check if the issue is about the same UI component, file type, or workflow step
+   - Evaluate relevance based on:
+     * Core concept match (most important)
+     * Component/context match
+     * Action/behavior match (user's requested action may differ from issue's proposed solution)
+   - **If the issue mentions similar features but in a different context, mark it as "related" not "exact match"**
+
+4. **Display Results**
+   - **First**, list the searches you performed, for transparency:
+     ```
+     🔍 Searches performed:
+     - "DataLoader null pointer Windows"
+     - "NullReferenceException loader crash"
+     - "Windows DataLoader crash"
+     ```
+   - **Then**, summarize results in a Markdown table with the following columns: #, Title, State, Relevance, Notes. Use emojis for state (🔓 Open, 🔒 Closed) and relevance (✅ Exact, 🔗 Related).
+
+5. **Conclude**
+   - Matching context → recommend most relevant issue
+   - Different context → explain difference and suggest new issue
+   - Nothing found → suggest title and keywords for new issue
+
+<output_style>
+## Style
+- Keep explanations short and scannable
+- Use Markdown formatting (bullets, tables)
+- Go straight to findings—no preamble
+</output_style>
+
+## Example
+
+**User:**
+> "I get an access violation when I close the app after running the renderer."
+
+**Assistant:**
+🔍 **Searches performed:**
+- "renderer crash" (core concepts)
+- "renderer exit crash" (core + action)
+- "access violation renderer shutdown" (original phrasing)
+- "renderer close segmentation fault" (synonym variation)
+
+Found 2 similar issues:
+| # | Title | State | Relevance | Notes |
+|---|--------|--------|-----------|-------|
+| #201 | Renderer crash on exit | 🔓 Open | ✅ Exact | Matches shutdown sequence and context |
+| #178 | App closes unexpectedly after render | 🔒 Closed | 🔗 Related | Similar timing but fixed in v2.3 |
+
+✅ **You can comment on #201** as it matches your issue.
+
+---
+
+### 📝 Alternative: Suggested New Issue
+
+**Title:**
+Renderer access violation on app exit
+
+**Description:**
+The application crashes with an access violation error when closing after running the renderer. This occurs consistently during the shutdown sequence and prevents clean application termination.
+
+**Keywords:**
+`renderer`, `shutdown`, `access-violation`, `crash`

.vscode/launch.json

@@ -588,11 +588,33 @@
 			]
 		},
 		{
-			"name": "Monaco Editor Playground",
+			"name": "Monaco Editor - Playground",
 			"type": "chrome",
 			"request": "launch",
-			"url": "http://localhost:5001",
-			"preLaunchTask": "Launch Http Server",
+			"url": "https://microsoft.github.io/monaco-editor/playground.html?source=http%3A%2F%2Flocalhost%3A5199%2Fbuild%2Fmonaco-editor-playground%2Findex.ts%3Fesm#example-creating-the-editor-hello-world",
+			"preLaunchTask": "Launch Monaco Editor Vite",
+			"presentation": {
+				"group": "monaco",
+				"order": 4
+			}
+		},
+		{
+			"name": "Monaco Editor - Self Contained Diff Editor",
+			"type": "chrome",
+			"request": "launch",
+			"url": "http://localhost:5199/build/monaco-editor-playground/index.html",
+			"preLaunchTask": "Launch Monaco Editor Vite",
+			"presentation": {
+				"group": "monaco",
+				"order": 4
+			}
+		},
+		{
+			"name": "Monaco Editor - Workbench",
+			"type": "chrome",
+			"request": "launch",
+			"url": "http://localhost:5199/build/monaco-editor-playground/workbench-vite.html",
+			"preLaunchTask": "Launch Monaco Editor Vite",
 			"presentation": {
 				"group": "monaco",
 				"order": 4

.vscode/settings.json

@@ -203,7 +203,6 @@
 	// "application.experimental.rendererProfiling": true, // https://github.com/microsoft/vscode/issues/265654
 	"editor.aiStats.enabled": true, // Team selfhosting on ai stats
 	"chat.emptyState.history.enabled": true,
-	"chat.agentSessionsViewLocation": "view",
 	"chat.promptFilesRecommendations": {
 		"plan-fast": true,
 		"plan-deep": true

.vscode/tasks.json

@@ -279,9 +279,12 @@
 			"detail": "node_modules/tsec/bin/tsec -p src/tsconfig.json --noEmit"
 		},
 		{
-			"label": "Launch Http Server",
+			"label": "Launch Monaco Editor Vite",
 			"type": "shell",
-			"command": "node_modules/.bin/ts-node -T ./scripts/playground-server",
+			"command": "npm run dev",
+			"options": {
+				"cwd": "./build/monaco-editor-playground/"
+			},
 			"isBackground": true,
 			"problemMatcher": {
 				"pattern": {
@@ -292,10 +295,7 @@
 					"beginsPattern": "never match",
 					"endsPattern": ".*"
 				}
-			},
-			"dependsOn": [
-				"Core - Build"
-			]
+			}
 		},
 		{
 			"label": "Launch MCP Server",

ThirdPartyNotices.txt

@@ -2277,7 +2277,7 @@ written authorization of the copyright holder.
 
 ---------------------------------------------------------
 
-vscode-codicons 0.0.14 - MIT and Creative Commons Attribution 4.0
+vscode-codicons 0.0.41 - MIT and Creative Commons Attribution 4.0
 https://github.com/microsoft/vscode-codicons
 
 Attribution 4.0 International

build/filters.js

@@ -49,6 +49,7 @@ module.exports.unicodeFilter = [
 	'!build/win32/**',
 	'!extensions/markdown-language-features/notebook-out/*.js',
 	'!extensions/markdown-math/notebook-out/**',
+	'!extensions/mermaid-chat-features/chat-webview-out/**',
 	'!extensions/ipynb/notebook-out/**',
 	'!extensions/notebook-renderers/renderer-out/**',
 	'!extensions/php-language-features/src/features/phpGlobalFunctions.ts',
@@ -140,6 +141,7 @@ module.exports.indentationFilter = [
 	'!**/*.dockerfile',
 
 	// except for built files
+	'!extensions/mermaid-chat-features/chat-webview-out/*.js',
 	'!extensions/markdown-language-features/media/*.js',
 	'!extensions/markdown-language-features/notebook-out/*.js',
 	'!extensions/markdown-math/notebook-out/*.js',

build/gulpfile.hygiene.js renamed to build/gulpfile.hygiene.mjs

@@ -2,19 +2,21 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
+import gulp from 'gulp';
+import es from 'event-stream';
+import path from 'path';
+import fs from 'fs';
+import task from './lib/task.js';
+import { hygiene } from './hygiene.mjs';
 
-const gulp = require('gulp');
-const es = require('event-stream');
-const path = require('path');
-const task = require('./lib/task');
-const { hygiene } = require('./hygiene');
+const dirName = path.dirname(new URL(import.meta.url).pathname);
 
 /**
  * @param {string} actualPath
  */
 function checkPackageJSON(actualPath) {
-	const actual = require(path.join(__dirname, '..', actualPath));
-	const rootPackageJSON = require('../package.json');
+	const actual = JSON.parse(fs.readFileSync(path.join(dirName, '..', actualPath), 'utf8'));
+	const rootPackageJSON = JSON.parse(fs.readFileSync(path.join(dirName, '..', 'package.json'), 'utf8'));
 	const checkIncluded = (set1, set2) => {
 		for (const depName in set1) {
 			const depVersion = set1[depName];

build/gulpfile.js

@@ -49,5 +49,5 @@ process.on('unhandledRejection', (reason, p) => {
 });
 
 // Load all the gulpfiles only if running tasks other than the editor tasks
-require('glob').sync('gulpfile.*.js', { cwd: __dirname })
+require('glob').sync('gulpfile.*.{js,mjs}', { cwd: __dirname })
 	.forEach(f => require(`./${f}`));