Enable support for Http based MCP resources (#276580)

* Enabling Http enabled MCP resources

* Updating with review comments

* tidy nits

---------

Co-authored-by: Connor Peet <[email protected]>

Author: dileepyavan

src/vs/workbench/contrib/mcp/common/mcpResourceFilesystem.ts

@@ -17,10 +17,12 @@ import { equalsIgnoreCase } from '../../../../base/common/strings.js';
 import { URI } from '../../../../base/common/uri.js';
 import { createFileSystemProviderError, FileChangeType, FileSystemProviderCapabilities, FileSystemProviderErrorCode, FileType, IFileChange, IFileDeleteOptions, IFileOverwriteOptions, IFileReadStreamOptions, IFileService, IFileSystemProviderWithFileAtomicReadCapability, IFileSystemProviderWithFileReadStreamCapability, IFileSystemProviderWithFileReadWriteCapability, IFileWriteOptions, IStat, IWatchOptions } from '../../../../platform/files/common/files.js';
 import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js';
+import { IWebContentExtractorService } from '../../../../platform/webContentExtractor/common/webContentExtractor.js';
 import { IWorkbenchContribution } from '../../../common/contributions.js';
 import { McpServer } from './mcpServer.js';
 import { McpServerRequestHandler } from './mcpServerRequestHandler.js';
 import { IMcpService, McpCapability, McpResourceURI } from './mcpTypes.js';
+import { canLoadMcpNetworkResourceDirectly } from './mcpTypesUtils.js';
 import { MCP } from './modelContextProtocol.js';
 
 const MOMENTARY_CACHE_DURATION = 3000;
@@ -65,6 +67,7 @@ export class McpResourceFilesystem extends Disposable implements IWorkbenchContr
 	constructor(
 		@IInstantiationService private readonly _instantiationService: IInstantiationService,
 		@IFileService private readonly _fileService: IFileService,
+		@IWebContentExtractorService private readonly _webContentExtractorService: IWebContentExtractorService,
 	) {
 		super();
 		this._register(this._fileService.registerProvider(McpResourceURI.scheme, this));
@@ -164,7 +167,6 @@ export class McpResourceFilesystem extends Disposable implements IWorkbenchContr
 		if (forSameURI.length > 0) {
 			throw createFileSystemProviderError(`File is not a directory`, FileSystemProviderErrorCode.FileNotADirectory);
 		}
-
 		const resourcePathParts = resourceURI.pathname.split('/');
 
 		const output = new Map<string, FileType>();
@@ -273,12 +275,26 @@ export class McpResourceFilesystem extends Disposable implements IWorkbenchContr
 
 	private async _readURIInner(uri: URI, token?: CancellationToken): Promise<IReadData> {
 		const { resourceURI, server } = this._decodeURI(uri);
-		const res = await McpServer.callOn(server, r => r.readResource({ uri: resourceURI.toString() }, token), token);
+		const matchedServer = this._mcpService.servers.get().find(s => s.definition.id === server.definition.id);
+
+		//check for http/https resources and use web content extractor service to fetch the contents.
+		if (canLoadMcpNetworkResourceDirectly(resourceURI, matchedServer)) {
+			const extractURI = URI.parse(resourceURI.toString());
+			const result = (await this._webContentExtractorService.extract([extractURI], { followRedirects: false })).at(0);
+			if (result?.status === 'ok') {
+				return {
+					contents: [{ uri: resourceURI.toString(), text: result.result }],
+					resourceURI,
+					forSameURI: [{ uri: resourceURI.toString(), text: result.result }]
+				};
+			}
+		}
 
+		const res = await McpServer.callOn(server, r => r.readResource({ uri: resourceURI.toString() }, token), token);
 		return {
 			contents: res.contents,
 			resourceURI,
-			forSameURI: res.contents.filter(c => equalsUrlPath(c.uri, resourceURI)),
+			forSameURI: res.contents.filter(c => equalsUrlPath(c.uri, resourceURI))
 		};
 	}
 }

src/vs/workbench/contrib/mcp/common/mcpTypesUtils.ts

@@ -9,7 +9,8 @@ import { CancellationError } from '../../../../base/common/errors.js';
 import { DisposableStore } from '../../../../base/common/lifecycle.js';
 import { autorun } from '../../../../base/common/observable.js';
 import { ToolDataSource } from '../../chat/common/languageModelToolsService.js';
-import { IMcpServer, IMcpServerStartOpts, IMcpService, McpConnectionState, McpServerCacheState } from './mcpTypes.js';
+import { IMcpServer, IMcpServerStartOpts, IMcpService, McpConnectionState, McpServerCacheState, McpServerTransportType } from './mcpTypes.js';
+
 
 /**
  * Waits up to `timeout` for a server passing the filter to be discovered,
@@ -91,3 +92,24 @@ export function mcpServerToSourceData(server: IMcpServer): ToolDataSource {
 		definitionId: server.definition.id
 	};
 }
+
+
+/**
+ * Validates whether the given HTTP or HTTPS resource is allowed for the specified MCP server.
+ *
+ * @param resource The URI of the resource to validate.
+ * @param server The MCP server instance to validate against, or undefined.
+ * @returns True if the resource request is valid for the server, false otherwise.
+ */
+export function canLoadMcpNetworkResourceDirectly(resource: URL, server: IMcpServer | undefined) {
+	let isResourceRequestValid = false;
+	if (resource.protocol === 'http:') {
+		const launch = server?.connection.get()?.launchDefinition;
+		if (launch && launch.type === McpServerTransportType.HTTP && launch.uri.authority.toLowerCase() === resource.hostname.toLowerCase()) {
+			isResourceRequestValid = true;
+		}
+	} else if (resource.protocol === 'https:') {
+		isResourceRequestValid = true;
+	}
+	return isResourceRequestValid;
+}