get placeholder to be read by screen reader for chat inputs #276195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
requested review from
Copilot and
roblourens
and removed request for
Copilot
roblourens
reviewed
Nov 10, 2025
src/vs/workbench/contrib/chat/browser/contrib/chatInputEditorContrib.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes accessibility issue #269070 by making chat input placeholders readable by screen readers. The change adds aria-placeholder attributes to chat input fields, ensuring that screen reader users can hear the placeholder text that sighted users see.
Key Changes
- Added
updateAriaPlaceholder()method to dynamically set/removearia-placeholderattribute on the native edit context DOM node - Integrated aria-placeholder updates into the existing placeholder rendering logic to ensure they stay synchronized with visual placeholders
dmitrivMS
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #269070
The active element is this and that lacks aria info. Applies to all chat inputs.
Before:
After: