history - fix issue with actions being no-op if window opened #276427
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the button click handler in the recently opened items picker to allow the "window opened" indicator buttons (folder/workspace) to also trigger the removal action.
- Extends the removal condition to include
windowOpenedRecentlyOpenedFolderandwindowOpenedRecentlyOpenedWorkspacebuttons alongside the existingremoveFromRecentlyOpenedbutton
|
|
||
| // Remove | ||
| if (context.button === this.removeFromRecentlyOpened) { | ||
| if (context.button === this.removeFromRecentlyOpened || context.button === this.windowOpenedRecentlyOpenedFolder || context.button === this.windowOpenedRecentlyOpenedWorkspace) { |
There was a problem hiding this comment.
The window opened indicator buttons (windowOpenedRecentlyOpenedFolder and windowOpenedRecentlyOpenedWorkspace) should not trigger removal. Looking at lines 242-248, these buttons are shown when kind.isOpenedInWindow is true, and they're informational indicators with tooltips like 'Folder Opened in a Window' (line 67). Only the removeFromRecentlyOpened button (lines 49-52) is designed for removal with tooltip 'Remove from Recently Opened'. Making informational buttons trigger removal actions creates a confusing and unintended behavior where clicking an indicator accidentally removes the item.
| if (context.button === this.removeFromRecentlyOpened || context.button === this.windowOpenedRecentlyOpenedFolder || context.button === this.windowOpenedRecentlyOpenedWorkspace) { | |
| if (context.button === this.removeFromRecentlyOpened) { |
No description provided.