enable a few notebook smoke tests #276793
Merged
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds logging to the notebook cell focus mechanism and runs specific tests 50 times to help diagnose focus-related issues. The changes include:
- Adding logging statements to track focus behavior in markup cells
- Adding a log statement to track notebook cell focus in the editor widget
- Wrapping three notebook tests in a loop to run 50 iterations each for stress testing
- Minor code formatting improvements (brace placement)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/smoke/src/areas/notebook/notebook.test.ts | Wraps three tests in a for-loop to run 50 iterations each, enabling stress testing of notebook cell operations |
| src/vs/workbench/contrib/notebook/browser/view/cellParts/markupCell.ts | Adds INotebookLoggingService injection and detailed logging in focusEditorIfNeeded() method to track focus behavior |
| src/vs/workbench/contrib/notebook/browser/view/cellParts/codeCell.ts | Fixes brace placement for better code formatting |
| src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts | Adds a log statement to track when notebook cells are focused |
src/vs/workbench/contrib/notebook/browser/view/cellParts/markupCell.ts
Outdated
Show resolved
Hide resolved
amunger
force-pushed
the
aamunger/smokeFlake
branch
from
a615702 to
21fb798
Compare
amunger
changed the title
justschen
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.