fix edge case with previously approved tools chat.tools.eligibleForAutoApproval
#277590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an edge case where previously approved tools could bypass the eligibility check defined by the chat.tools.eligibleForAutoApproval configuration setting. The fix ensures that tools explicitly marked as ineligible for auto-approval will never be auto-confirmed, even if the user had previously approved them.
Key Changes
- Added an early eligibility check in
shouldAutoConfirm()before checking for previous user approvals - Removed a TODO comment that is now obsolete since the issue it mentioned has been addressed
roblourens
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/microsoft/vscode-internalbacklog/issues/6255