Sync with OS (#609)

* Sync with OS commit 84854a6c2beef7430ac8886c7553166e9153d825

* Run clang-format on changes

* Sync build break fix

* Another round of build fixes

* Test fix

* Work around an unfortunate linker issue

* Accidental duplicate

Author: dunhor

include/wil/Tracelogging.h

@@ -530,8 +530,8 @@ class TraceLoggingProvider : public details::IFailureCallback
     static bool WasAlreadyReportedToTelemetry(long failureId) WI_NOEXCEPT
     {
         static long volatile s_lastFailureSeen = -1;
-        auto wasSeen = (s_lastFailureSeen == failureId);
-        s_lastFailureSeen = failureId;
+        long oldValue = InterlockedExchange(&s_lastFailureSeen, failureId);
+        auto wasSeen = (oldValue == failureId);
         return wasSeen;
     }
 
@@ -4731,6 +4731,49 @@ WIL_WARN_DEPRECATED_1612_PRAGMA("IMPLEMENT_TRACELOGGING_CLASS")
         varName8, \
         TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA), \
         TelemetryPrivacyDataTag(PrivacyTag))
+#define DEFINE_COMPLIANT_CRITICAL_DATA_EVENT_PARAM9( \
+    EventId, \
+    PrivacyTag, \
+    VarType1, \
+    varName1, \
+    VarType2, \
+    varName2, \
+    VarType3, \
+    varName3, \
+    VarType4, \
+    varName4, \
+    VarType5, \
+    varName5, \
+    VarType6, \
+    varName6, \
+    VarType7, \
+    varName7, \
+    VarType8, \
+    varName8, \
+    VarType9, \
+    varName9) \
+    DEFINE_TRACELOGGING_EVENT_PARAM9( \
+        EventId, \
+        VarType1, \
+        varName1, \
+        VarType2, \
+        varName2, \
+        VarType3, \
+        varName3, \
+        VarType4, \
+        varName4, \
+        VarType5, \
+        varName5, \
+        VarType6, \
+        varName6, \
+        VarType7, \
+        varName7, \
+        VarType8, \
+        varName8, \
+        VarType9, \
+        varName9, \
+        TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA), \
+        TelemetryPrivacyDataTag(PrivacyTag))
 
 #define DEFINE_COMPLIANT_CRITICAL_DATA_EVENT_CV(EventId, PrivacyTag) \
     DEFINE_TRACELOGGING_EVENT_CV(EventId, TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA), TelemetryPrivacyDataTag(PrivacyTag))

include/wil/coroutine.h

@@ -328,7 +328,7 @@ struct result_holder
     result_holder(result_holder const&) = delete;
     void operator=(result_holder const&) = delete;
 
-    ~result_holder() noexcept(false)
+    ~result_holder() noexcept
     {
         if (restricted_error && g_pfnDestroyRestrictedErrorInformation)
         {
@@ -342,10 +342,9 @@ struct result_holder
             result.wrap.~result_wrapper();
             break;
         case result_status::error:
-            // Rethrow unobserved exception. Delete this line to
-            // discard unobserved exceptions.
-            if (result.error)
-                std::rethrow_exception(result.error);
+            // Discard unobserved exception. There is nowhere to report it,
+            // and abandonment might validly happen if an exception occurs
+            // before the owner of the task can await it.
             result.error.~exception_ptr();
         }
     }
@@ -532,11 +531,25 @@ struct task_promise : promise_base<T>
         this->emplace_value(wistd::forward<U>(value));
     }
 
+    // Workaround a bug in MSVC where it does not properly deduce the return type.
+    // Using a constraint is simpler and does not have the issue.
+#if _HAS_CXX20
+
+    void return_value(T const& value)
+        requires(!wistd::is_reference_v<T>)
+    {
+        this->emplace_value(value);
+    }
+
+#else
+
     template <typename Dummy = void>
     wistd::enable_if_t<!wistd::is_reference_v<T>, Dummy> return_value(T const& value)
     {
         this->emplace_value(value);
     }
+
+#endif
 };
 
 template <>