add rule for enforcing terrascan pre-commit hook #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantord
force-pushed
the
add-terrascan-pre-commit-enforcement
branch
from
51ffe55 to
b720254
Compare
Co-authored-by: Giuseppe Scuglia <[email protected]>
kantord
force-pushed
the
add-terrascan-pre-commit-enforcement
branch
from
b720254 to
4b29121
Compare
evankanderson
approved these changes
Jan 10, 2025
Member
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
Similar comments to #241
| @@ -0,0 +1,19 @@ | |||
| tests: | |||
| - name: "Should have Talisman pre-commit hook configured" | |||
Member
There was a problem hiding this comment.
Suggested change
| - name: "Should have Talisman pre-commit hook configured" | |
| - name: "Should have Terrascan pre-commit hook configured" |
| expect: "pass" | ||
| git: | ||
| repo_base: correct | ||
| - name: "Should fail Talisman pre-commit hook is not configured" |
Member
There was a problem hiding this comment.
Suggested change
| - name: "Should fail Talisman pre-commit hook is not configured" | |
| - name: "Should fail Terrascan pre-commit hook is not configured" |
Comment on lines
+40
to
+41
| import future.keywords.if | ||
| import future.keywords.every |
Member
There was a problem hiding this comment.
Suggested change
| import future.keywords.if | |
| import future.keywords.every | |
| import rego.v1 |
| hooks[hook_id].id == "terraform-pre-commit" | ||
| } | ||
|
|
||
| message := "" if allow |
Member
There was a problem hiding this comment.
Suggested change
| message := "" if allow | |
| message := "Terrascan pre-commit hook is not configured for the repository" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Giuseppe Scuglia [email protected]