fem: make base isoparametric segment class a template of the dimension

Author: Pawel024

lib/mito/fem/elements/IsoparametricEmbeddedSegment.h

@@ -9,22 +9,22 @@
 
 // DESIGN NOTES
 // Class {IsoparametricSegment} represents a first order simplex (segment) equipped with parametric
-// coordinates.
+// coordinates. The template parameter D specifies the dimension of the physical space in which
+// the segment lives (D=1 for a segment in 1D, D=2 for a segment embedded in 2D, etc.).
 
 
 namespace mito::fem {
 
+    template <int dim>
     class IsoparametricSegment : public utilities::Invalidatable {
       public:
-        // the dimension of the physical space
-        static constexpr int dim = 1;
         // the discretization node type
         using discretization_node_type = discrete::discretization_node_t;
         // the underlying cell type
         using cell_type = geometry::segment_t<dim>;
 
       protected:
-        // cartesian coordinates in 1D
+        // cartesian coordinates in dim dimensions
         using coordinates_type = geometry::coordinates_t<dim, geometry::CARTESIAN>;
         // the coordinate system type
         using coordinate_system_type = geometry::coordinate_system_t<coordinates_type>;

lib/mito/fem/elements/IsoparametricSegment.h

@@ -19,7 +19,6 @@
 // classes implementation
 #include "IsoparametricSegment.h"
 #include "IsoparametricTriangle.h"
-#include "IsoparametricEmbeddedSegment.h"
 #include "Discretizer.h"
 
 // library of finite elements

lib/mito/fem/elements/public.h

@@ -14,7 +14,7 @@
 
 namespace mito::fem {
 
-    class IsoparametricSegmentP1 : public IsoparametricSegment {
+    class IsoparametricSegmentP1 : public IsoparametricSegment<1> {
 
       public:
         // the degree of the finite element
@@ -38,7 +38,7 @@ namespace mito::fem {
         inline IsoparametricSegmentP1(
             const cell_type & geometric_simplex, const coordinate_system_type & coord_system,
             const connectivity_type & connectivity) :
-            IsoparametricSegment(geometric_simplex, coord_system),
+            IsoparametricSegment<1>(geometric_simplex, coord_system),
             _connectivity(connectivity)
         {}
 

lib/mito/fem/elements/seg1/IsoparametricSegmentP1.h

@@ -8,15 +8,15 @@
 
 
 // DESIGN NOTES
-// Class {IsoparametricEmbeddedSegmentP1} represents a first order simplex (segment) living in 2D
+// Class {IsoparametricEmbeddedSegmentP1} represents a first order simplex (segment) embedded in 2D
 // cartesian space, equipped with linear shape functions defined in the 1D parametric space.
 // The key difference from IsoparametricSegmentP1 is the non-square Jacobian (2x1 matrix) and
 // the gradient computation that accounts for the embedded geometry.
 
 
 namespace mito::fem {
 
-    class IsoparametricEmbeddedSegmentP1 : public IsoparametricEmbeddedSegment {
+    class IsoparametricEmbeddedSegmentP1 : public IsoparametricSegment<2> {
 
       public:
         // the degree of the finite element
@@ -40,7 +40,7 @@ namespace mito::fem {
         inline IsoparametricEmbeddedSegmentP1(
             const cell_type & geometric_simplex, const coordinate_system_type & coord_system,
             const connectivity_type & connectivity) :
-            IsoparametricEmbeddedSegment(geometric_simplex, coord_system),
+            IsoparametricSegment<2>(geometric_simplex, coord_system),
             _connectivity(connectivity)
         {}