Skip to content

Commit b2057ab

Browse files
committed
Minor cleanup in *_projective integrators
1 parent f024531 commit b2057ab

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/python/python/ad/projective.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ def eval_indirect_integrand(self,
594594
result = dr.select(active, weight * fS * fB * fE * dr.rcp(ss.pdf), 0)
595595

596596
# Compute the motion of the boundary segment if this is not a preprocess
597-
if preprocess: # TODO cleanup
597+
if preprocess:
598598
return dr.abs(result), wavelengths, mi.Point2f(0)
599599
else:
600600
si = dr.zeros(mi.SurfaceInteraction3f)
@@ -628,15 +628,11 @@ def __init__(self, mesh_proj_algo, max_walk, max_jump) -> None:
628628

629629
@dr.syntax
630630
def mesh_walk(self,
631-
si_: mi.SurfaceInteraction3f,
631+
si: mi.SurfaceInteraction3f,
632632
viewpoint: mi.Point3f,
633633
state: mi.UInt64,
634634
active: mi.Bool,
635635
max_move: int):
636-
# TODO: This copy is necessary for "Dr.Jit reasons". Should be fixed
637-
# when Dr.Jit uses nanobind
638-
si = mi.SurfaceInteraction3f(si_)
639-
640636
ss = dr.zeros(mi.SilhouetteSample3f)
641637
sampler = mi.PCG32(dr.width(si), state)
642638

@@ -665,15 +661,11 @@ def mesh_walk(self,
665661
@dr.syntax
666662
def mesh_jump(self,
667663
scene: mi.Scene,
668-
si_: mi.SurfaceInteraction3f,
664+
si: mi.SurfaceInteraction3f,
669665
viewpoint: mi.Point3f,
670666
state: mi.UInt64,
671667
active: mi.Bool,
672668
max_jump: int):
673-
# TODO: This copy is necessary for "Dr.Jit reasons". Should be fixed
674-
# when Dr.Jit uses nanobind
675-
si = mi.SurfaceInteraction3f(si_)
676-
677669
shape = si.shape
678670
sampler = mi.PCG32(dr.width(si), state)
679671

0 commit comments

Comments
 (0)