fix(frontend): conditionally apply httpclose default for http type only (#6)

The httpclose parameter had an unconditional default value of
'http-keep-alive' which caused validation to fail for https/tcp
frontend types even when the user didn't specify the parameter.

Now the default is only applied when type='http', allowing https
and tcp frontends to work without explicitly setting httpclose.

Author: morey-tech

docs/modules/pfsense_haproxy_frontend.md

@@ -14,7 +14,7 @@ Manage pfSense HAProxy frontends
 | status | str | no | - | - | Frontend status (enabled/disabled). |
 | desc | str | no | - | - | Frontend description. |
 | type | str | no | http | http, https, tcp | Frontend type/mode. `http` - HTTP/HTTPS with offloading (SSL termination); `https` - SSL/HTTPS (TCP mode) for SNI-based routing; `tcp` - Plain TCP proxying for non-HTTP protocols. |
-| httpclose | str | no | http-keep-alive | http-keep-alive | HTTP close mode for connection handling. Only valid for `http` type frontends. |
+| httpclose | str | no | - | http-keep-alive | HTTP close mode for connection handling. Only valid for `http` type frontends. Defaults to `http-keep-alive` when `type=http` and not specified. |
 | backend_serverpool | str | no | - | - | Backend server pool to use. |
 | ssloffloadcert | str | no | - | - | SSL certificate for offloading. |
 | ssloffloadcert_type_search | str | no | descr | - | Field type to search for SSL certificate. |

plugins/module_utils/haproxy_frontend.py

@@ -14,7 +14,7 @@
     status=dict(required=False, type='str'),
     desc=dict(required=False, type='str'),
     type=dict(default='http', choices=['http', 'https', 'tcp']),
-    httpclose=dict(default='http-keep-alive', choices=['http-keep-alive']),
+    httpclose=dict(required=False, choices=['http-keep-alive']),
     backend_serverpool=dict(required=False, type='str'),
     ssloffloadcert=dict(required=False, type='str'),
     ssloffloadcert_type_search=dict(default='descr', type='str'),
@@ -63,7 +63,11 @@ def _params_to_obj(self):
             self._get_ansible_param(obj, 'status')
             # Only add httpclose for HTTP mode (not https or tcp)
             if obj.get('type', 'http') == 'http':
-                self._get_ansible_param(obj, 'httpclose')
+                # Apply default if not explicitly set
+                if self.params.get('httpclose') is None:
+                    obj['httpclose'] = 'http-keep-alive'
+                else:
+                    self._get_ansible_param(obj, 'httpclose')
             self._get_ansible_param(obj, 'backend_serverpool')
             self._get_ansible_param(obj, 'max_connections')
 

plugins/modules/pfsense_haproxy_frontend.py

@@ -47,10 +47,10 @@
     description:
       - HTTP close mode for connection handling.
       - Only valid for C(http) type frontends.
+      - Defaults to C(http-keep-alive) when C(type=http) and not specified.
     required: false
     type: str
     choices: ['http-keep-alive']
-    default: 'http-keep-alive'
   backend_serverpool:
     description: Backend server pool to use.
     required: false