Skip to content

Commit cb289f3

Browse files
Merge remote-tracking branch 'origin/feature/requirements-typo3-alignment' into feature/requirements-database-grants
2 parents e0334a7 + 37d443e commit cb289f3

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

deployer/requirements/functions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ function detectPackageVersion(string $command): ?string
176176
try {
177177
$output = trim(run($versionCmd));
178178

179-
if ($output !== '' && preg_match('/(\d+[\d.]+)/', $output, $matches)) {
179+
if ($output !== '' && preg_match('/(\d+[\d.]*)/', $output, $matches)) {
180180
return $matches[1];
181181
}
182182
} catch (RunException) {

deployer/requirements/task/check_image_processing.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
$gmMinVersion = get('requirements_graphicsmagick_min_version');
1515
$imMinVersion = get('requirements_imagemagick_min_version');
16+
$gmVersionFail = false;
1617

1718
// Try GraphicsMagick first (recommended)
1819
try {
@@ -27,6 +28,8 @@
2728

2829
return;
2930
}
31+
32+
$gmVersionFail = "GraphicsMagick $actualVersion (required: >= $gmMinVersion)";
3033
}
3134
} catch (RunException) {
3235
// GraphicsMagick not available, try ImageMagick
@@ -55,6 +58,8 @@
5558
addRequirementRow(
5659
'Image processing',
5760
REQUIREMENT_FAIL,
58-
"Neither GraphicsMagick (>= $gmMinVersion) nor ImageMagick (>= $imMinVersion) found"
61+
$gmVersionFail !== false
62+
? "$gmVersionFail — ImageMagick (>= $imMinVersion) not found"
63+
: "Neither GraphicsMagick (>= $gmMinVersion) nor ImageMagick (>= $imMinVersion) found"
5964
);
6065
})->hidden();

0 commit comments

Comments
 (0)