fix(breach-alerts): remove session-dependent data from email notification

Fixes [MNTOR-5097]

Author: kschelonka

src/scripts/cronjobs/emailBreachAlerts.tsx

@@ -28,16 +28,7 @@ import { renderEmail } from "../../emails/renderEmail";
 import { BreachAlertEmail } from "../../emails/templates/breachAlert/BreachAlertEmail";
 import { getCronjobL10n } from "../../app/functions/l10n/cronjobs";
 import { sanitizeSubscriberRow } from "../../app/functions/server/sanitize";
-import { getSubscriberBreaches } from "../../app/functions/server/getSubscriberBreaches";
 import { getSignupLocaleCountry } from "../../emails/functions/getSignupLocaleCountry";
-import { refreshStoredScanResults } from "../../app/functions/server/refreshStoredScanResults";
-import { isEligibleForPremium } from "../../app/functions/universal/premium";
-import { hasPremium } from "../../app/functions/universal/user";
-import {
-  DashboardSummary,
-  getDashboardSummary,
-} from "../../app/functions/server/dashboard";
-import { getScanResultsWithBroker } from "../../db/tables/onerep_scans";
 import { logger } from "../../app/functions/server/logging";
 import { getExperimentationIdFromSubscriber } from "../../app/functions/server/getExperimentationId";
 import { getExperiments } from "../../app/functions/server/getExperiments";
@@ -284,25 +275,6 @@ export async function poll(
              */
             const assumedCountryCode = getSignupLocaleCountry(recipient);
 
-            // The unit tests are currently too complex for me to write
-            // a proper test for this, and I need to understand the code
-            // better to be able to refactor it to make it more amenable
-            // to simple tests. Hence, I don't have a test for this yet:
-            /* c8 ignore next 3 */
-            if (typeof recipient.onerep_profile_id === "number") {
-              await refreshStoredScanResults(recipient.onerep_profile_id);
-            }
-
-            const dataSummary: DashboardSummary | undefined =
-              // We currently need the data summary for the `<DataPointCount>` in
-              // `<BreachAlertEmail>`, which is only shown for free users who are
-              // eligible for Plus (i.e. are in the US) who have run a scan.
-              // Since it's somewhat expensive to run the queries to fetch this data,
-              // we only do it for those users.
-              isEligibleForPremium(assumedCountryCode) && !hasPremium(recipient)
-                ? await getDataSummary(recipient, assumedCountryCode)
-                : undefined;
-
             const subject = l10n.getString("email-breach-alert-all-subject");
             const experimentationId =
               await getExperimentationIdFromSubscriber(recipient);
@@ -322,7 +294,7 @@ export async function poll(
                   breachedEmail={breachedEmail}
                   utmCampaignId={utmCampaignId}
                   subscriber={recipient}
-                  dataSummary={dataSummary}
+                  dataSummary={undefined}
                   experimentData={experimentData["Features"]}
                 />,
               ),
@@ -380,21 +352,6 @@ export async function poll(
   }
 }
 
-async function getDataSummary(
-  recipient: SubscriberRow | (SubscriberRow & EmailAddressRow),
-  assumedCountryCode: string,
-): Promise<DashboardSummary> {
-  const allSubscriberBreaches = await getSubscriberBreaches({
-    fxaUid: recipient.fxa_uid,
-    countryCode: assumedCountryCode,
-  });
-  const scanData = await getScanResultsWithBroker(
-    recipient.onerep_profile_id,
-    hasPremium(recipient),
-  );
-  return getDashboardSummary(scanData.results, allSubscriberBreaches);
-}
-
 /* c8 ignore start */
 export function createPubSubClient() {
   let options = {};