fix tests

Author: codemist

src/app/functions/server/getExperiments.test.ts

@@ -149,42 +149,6 @@ describe("getExperiments", () => {
     );
   });
 
-  it("calls Cirrus V1 when featurn flag is disabled", async () => {
-    process.env.NIMBUS_SIDECAR_URL = "https://cirrus.example/base";
-    getEnabledFeatureFlagsMock.mockReturnValue([] as FeatureFlagName[]);
-    headersMock.mockResolvedValue(new Headers([]));
-
-    const featuresJson = { bar: { enabled: false } };
-    fetchMock.mockResolvedValue({
-      ok: true,
-      status: 200,
-      json: () => Promise.resolve(featuresJson),
-    } as Response);
-
-    const { getExperiments } = await import("./getExperiments");
-
-    const result = await getExperiments({
-      experimentationId: "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa",
-      locale: "en-US",
-      countryCode: "us",
-    });
-
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-    const [calledUrl] = fetchMock.mock.calls[0];
-    expect(calledUrl.toString()).toBe(
-      "https://cirrus.example/base/v1/features",
-    );
-
-    expect(result).toEqual({ Features: featuresJson });
-    expect(loggerMock.info).toHaveBeenCalledWith(
-      "Sending request to Cirrus",
-      expect.objectContaining({
-        serverUrl: "https://cirrus.example/base/v1/features",
-        previewMode: false,
-      }),
-    );
-  });
-
   it("fallsback to defaultExperimentData when not experiment data is returned by Cirrus", async () => {
     process.env.NIMBUS_SIDECAR_URL = "https://cirrus.example";
     headersMock.mockResolvedValue(
@@ -266,31 +230,4 @@ describe("getExperiments", () => {
     expect(captureExceptionMock).toHaveBeenCalledTimes(1);
     expect(result).toEqual(defaultExperimentDataMock);
   });
-
-  it("logs error, captures exception, and returns defaultExperimentData on fetch throw", async () => {
-    process.env.NIMBUS_SIDECAR_URL = "https://cirrus.example/";
-    getEnabledFeatureFlagsMock.mockReturnValue([] as FeatureFlagName[]);
-    headersMock.mockResolvedValue(new Headers([]));
-
-    fetchMock.mockRejectedValue(new Error("error"));
-
-    const { getExperiments } = await import("./getExperiments");
-
-    const result = await getExperiments({
-      experimentationId: "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa",
-      locale: "nl-NL",
-      countryCode: "nl",
-    });
-
-    expect(loggerMock.error).toHaveBeenCalledWith(
-      "Could not connect to Cirrus",
-      expect.objectContaining({
-        serverUrl: new URL("https://cirrus.example/v1/features"),
-        previewMode: false,
-        flags: [],
-      }),
-    );
-    expect(captureExceptionMock).toHaveBeenCalledTimes(1);
-    expect(result).toEqual(defaultExperimentDataMock);
-  });
 });

src/app/functions/server/getExperiments.ts

@@ -42,9 +42,6 @@ export async function getExperiments(params: {
 
   const serverUrl = new URL(process.env.NIMBUS_SIDECAR_URL);
   const flags = await getEnabledFeatureFlags({ isSignedOut: true });
-  if (!serverUrl.pathname.endsWith("/")) {
-    serverUrl.pathname += "/";
-  }
   serverUrl.pathname += "v2/features";
 
   const nextHeaders = await loadNextHeaders();