-
Notifications
You must be signed in to change notification settings - Fork 2
Enterprise main merge 20251108 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al folder name r=cdupuis This is part 1, which will temporarily disable the translation so that new backups are created in a folder named "Restore Firefox", in accordance with the specification. More info is available here: https://bugzilla.mozilla.org/show_bug.cgi?id=1998693#c6 Differential Revision: https://phabricator.services.mozilla.com/D271674
… prefs r=profiles-reviewers,jhirsch Differential Revision: https://phabricator.services.mozilla.com/D271590
…viewers,sthompson Differential Revision: https://phabricator.services.mozilla.com/D271699
…oll.js. r=botond browser_test_background_tab_load_scroll.js has provided us a scenario swtiching tabs. It just had tested there's no discrepancy between the visual and the layout scroll offsets, it had not tested the scroll offsets exactly. Now the sticter checks test the layout offsets as it's supposed to be, before reloading the offset is 10000, after reloading, it's 20000. Differential Revision: https://phabricator.services.mozilla.com/D269336
…of relavei/instant scroll position updates if the APZC is default. r=botond Differential Revision: https://phabricator.services.mozilla.com/D269175
…h-reviewers,ahal Differential Revision: https://phabricator.services.mozilla.com/D270886
… file. DONTBUILD (not bothering with review, since this is just deleting an empty file) Differential Revision: https://phabricator.services.mozilla.com/D271727
…ion in New Tab settings r=home-newtab-reviewers,reemhamz - Removed conditional code around the "Support Firefox" settings. - Removed an obsolete setting: `browser.newtabpage.activity-stream.system.showSponsoredCheckboxes`. Differential Revision: https://phabricator.services.mozilla.com/D271723
…r=emilio,geckoview-reviewers,places-reviewers,layout-reviewers,valentin,m_kato Differential Revision: https://phabricator.services.mozilla.com/D271018
…ILD CLOSED TREE ach -> 745f36269f740ab7dd701a9b4788326fb01cf80b af -> 745f36269f740ab7dd701a9b4788326fb01cf80b an -> 745f36269f740ab7dd701a9b4788326fb01cf80b ar -> 745f36269f740ab7dd701a9b4788326fb01cf80b ast -> 745f36269f740ab7dd701a9b4788326fb01cf80b az -> 745f36269f740ab7dd701a9b4788326fb01cf80b be -> 745f36269f740ab7dd701a9b4788326fb01cf80b bg -> 745f36269f740ab7dd701a9b4788326fb01cf80b bn -> 745f36269f740ab7dd701a9b4788326fb01cf80b bo -> 745f36269f740ab7dd701a9b4788326fb01cf80b br -> 745f36269f740ab7dd701a9b4788326fb01cf80b brx -> 745f36269f740ab7dd701a9b4788326fb01cf80b bs -> 745f36269f740ab7dd701a9b4788326fb01cf80b ca -> 745f36269f740ab7dd701a9b4788326fb01cf80b ca-valencia -> 745f36269f740ab7dd701a9b4788326fb01cf80b cak -> 745f36269f740ab7dd701a9b4788326fb01cf80b ckb -> 745f36269f740ab7dd701a9b4788326fb01cf80b cs -> 745f36269f740ab7dd701a9b4788326fb01cf80b cy -> 745f36269f740ab7dd701a9b4788326fb01cf80b da -> 745f36269f740ab7dd701a9b4788326fb01cf80b de -> 745f36269f740ab7dd701a9b4788326fb01cf80b dsb -> 745f36269f740ab7dd701a9b4788326fb01cf80b el -> 745f36269f740ab7dd701a9b4788326fb01cf80b en-CA -> 745f36269f740ab7dd701a9b4788326fb01cf80b en-GB -> 745f36269f740ab7dd701a9b4788326fb01cf80b eo -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-AR -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-CL -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-ES -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-MX -> 745f36269f740ab7dd701a9b4788326fb01cf80b et -> 745f36269f740ab7dd701a9b4788326fb01cf80b eu -> 745f36269f740ab7dd701a9b4788326fb01cf80b fa -> 745f36269f740ab7dd701a9b4788326fb01cf80b ff -> 745f36269f740ab7dd701a9b4788326fb01cf80b fi -> 745f36269f740ab7dd701a9b4788326fb01cf80b fr -> 745f36269f740ab7dd701a9b4788326fb01cf80b fur -> 745f36269f740ab7dd701a9b4788326fb01cf80b fy-NL -> 745f36269f740ab7dd701a9b4788326fb01cf80b ga-IE -> 745f36269f740ab7dd701a9b4788326fb01cf80b gd -> 745f36269f740ab7dd701a9b4788326fb01cf80b gl -> 745f36269f740ab7dd701a9b4788326fb01cf80b gn -> 745f36269f740ab7dd701a9b4788326fb01cf80b gu-IN -> 745f36269f740ab7dd701a9b4788326fb01cf80b he -> 745f36269f740ab7dd701a9b4788326fb01cf80b hi-IN -> 745f36269f740ab7dd701a9b4788326fb01cf80b hr -> 745f36269f740ab7dd701a9b4788326fb01cf80b hsb -> 745f36269f740ab7dd701a9b4788326fb01cf80b hu -> 745f36269f740ab7dd701a9b4788326fb01cf80b hy-AM -> 745f36269f740ab7dd701a9b4788326fb01cf80b hye -> 745f36269f740ab7dd701a9b4788326fb01cf80b ia -> 745f36269f740ab7dd701a9b4788326fb01cf80b id -> 745f36269f740ab7dd701a9b4788326fb01cf80b is -> 745f36269f740ab7dd701a9b4788326fb01cf80b it -> 745f36269f740ab7dd701a9b4788326fb01cf80b ja -> 745f36269f740ab7dd701a9b4788326fb01cf80b ja-JP-mac -> 745f36269f740ab7dd701a9b4788326fb01cf80b ka -> 745f36269f740ab7dd701a9b4788326fb01cf80b kab -> 745f36269f740ab7dd701a9b4788326fb01cf80b kk -> 745f36269f740ab7dd701a9b4788326fb01cf80b km -> 745f36269f740ab7dd701a9b4788326fb01cf80b kn -> 745f36269f740ab7dd701a9b4788326fb01cf80b ko -> 745f36269f740ab7dd701a9b4788326fb01cf80b lij -> 745f36269f740ab7dd701a9b4788326fb01cf80b lo -> 745f36269f740ab7dd701a9b4788326fb01cf80b lt -> 745f36269f740ab7dd701a9b4788326fb01cf80b ltg -> 745f36269f740ab7dd701a9b4788326fb01cf80b lv -> 745f36269f740ab7dd701a9b4788326fb01cf80b meh -> 745f36269f740ab7dd701a9b4788326fb01cf80b mk -> 745f36269f740ab7dd701a9b4788326fb01cf80b ml -> 745f36269f740ab7dd701a9b4788326fb01cf80b mr -> 745f36269f740ab7dd701a9b4788326fb01cf80b ms -> 745f36269f740ab7dd701a9b4788326fb01cf80b my -> 745f36269f740ab7dd701a9b4788326fb01cf80b nb-NO -> 745f36269f740ab7dd701a9b4788326fb01cf80b ne-NP -> 745f36269f740ab7dd701a9b4788326fb01cf80b nl -> 745f36269f740ab7dd701a9b4788326fb01cf80b nn-NO -> 745f36269f740ab7dd701a9b4788326fb01cf80b oc -> 745f36269f740ab7dd701a9b4788326fb01cf80b pa-IN -> 745f36269f740ab7dd701a9b4788326fb01cf80b pl -> 745f36269f740ab7dd701a9b4788326fb01cf80b pt-BR -> 745f36269f740ab7dd701a9b4788326fb01cf80b pt-PT -> 745f36269f740ab7dd701a9b4788326fb01cf80b rm -> 745f36269f740ab7dd701a9b4788326fb01cf80b ro -> 745f36269f740ab7dd701a9b4788326fb01cf80b ru -> 745f36269f740ab7dd701a9b4788326fb01cf80b sat -> 745f36269f740ab7dd701a9b4788326fb01cf80b sc -> 745f36269f740ab7dd701a9b4788326fb01cf80b scn -> 745f36269f740ab7dd701a9b4788326fb01cf80b sco -> 745f36269f740ab7dd701a9b4788326fb01cf80b si -> 745f36269f740ab7dd701a9b4788326fb01cf80b sk -> 745f36269f740ab7dd701a9b4788326fb01cf80b skr -> 745f36269f740ab7dd701a9b4788326fb01cf80b sl -> 745f36269f740ab7dd701a9b4788326fb01cf80b son -> 745f36269f740ab7dd701a9b4788326fb01cf80b sq -> 745f36269f740ab7dd701a9b4788326fb01cf80b sr -> 745f36269f740ab7dd701a9b4788326fb01cf80b sv-SE -> 745f36269f740ab7dd701a9b4788326fb01cf80b szl -> 745f36269f740ab7dd701a9b4788326fb01cf80b ta -> 745f36269f740ab7dd701a9b4788326fb01cf80b te -> 745f36269f740ab7dd701a9b4788326fb01cf80b tg -> 745f36269f740ab7dd701a9b4788326fb01cf80b th -> 745f36269f740ab7dd701a9b4788326fb01cf80b tl -> 745f36269f740ab7dd701a9b4788326fb01cf80b tr -> 745f36269f740ab7dd701a9b4788326fb01cf80b trs -> 745f36269f740ab7dd701a9b4788326fb01cf80b uk -> 745f36269f740ab7dd701a9b4788326fb01cf80b ur -> 745f36269f740ab7dd701a9b4788326fb01cf80b uz -> 745f36269f740ab7dd701a9b4788326fb01cf80b vi -> 745f36269f740ab7dd701a9b4788326fb01cf80b wo -> 745f36269f740ab7dd701a9b4788326fb01cf80b xh -> 745f36269f740ab7dd701a9b4788326fb01cf80b zh-CN -> 745f36269f740ab7dd701a9b4788326fb01cf80b zh-TW -> 745f36269f740ab7dd701a9b4788326fb01cf80b
…LD CLOSED TREE ach -> 745f36269f740ab7dd701a9b4788326fb01cf80b an -> 745f36269f740ab7dd701a9b4788326fb01cf80b ar -> 745f36269f740ab7dd701a9b4788326fb01cf80b ast -> 745f36269f740ab7dd701a9b4788326fb01cf80b az -> 745f36269f740ab7dd701a9b4788326fb01cf80b be -> 745f36269f740ab7dd701a9b4788326fb01cf80b bg -> 745f36269f740ab7dd701a9b4788326fb01cf80b bn -> 745f36269f740ab7dd701a9b4788326fb01cf80b br -> 745f36269f740ab7dd701a9b4788326fb01cf80b bs -> 745f36269f740ab7dd701a9b4788326fb01cf80b ca -> 745f36269f740ab7dd701a9b4788326fb01cf80b cak -> 745f36269f740ab7dd701a9b4788326fb01cf80b cs -> 745f36269f740ab7dd701a9b4788326fb01cf80b cy -> 745f36269f740ab7dd701a9b4788326fb01cf80b da -> 745f36269f740ab7dd701a9b4788326fb01cf80b de -> 745f36269f740ab7dd701a9b4788326fb01cf80b dsb -> 745f36269f740ab7dd701a9b4788326fb01cf80b el -> 745f36269f740ab7dd701a9b4788326fb01cf80b en-CA -> 745f36269f740ab7dd701a9b4788326fb01cf80b en-GB -> 745f36269f740ab7dd701a9b4788326fb01cf80b eo -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-AR -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-CL -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-ES -> 745f36269f740ab7dd701a9b4788326fb01cf80b es-MX -> 745f36269f740ab7dd701a9b4788326fb01cf80b et -> 745f36269f740ab7dd701a9b4788326fb01cf80b eu -> 745f36269f740ab7dd701a9b4788326fb01cf80b fa -> 745f36269f740ab7dd701a9b4788326fb01cf80b ff -> 745f36269f740ab7dd701a9b4788326fb01cf80b fi -> 745f36269f740ab7dd701a9b4788326fb01cf80b fr -> 745f36269f740ab7dd701a9b4788326fb01cf80b fy-NL -> 745f36269f740ab7dd701a9b4788326fb01cf80b ga-IE -> 745f36269f740ab7dd701a9b4788326fb01cf80b gd -> 745f36269f740ab7dd701a9b4788326fb01cf80b gl -> 745f36269f740ab7dd701a9b4788326fb01cf80b gn -> 745f36269f740ab7dd701a9b4788326fb01cf80b gu-IN -> 745f36269f740ab7dd701a9b4788326fb01cf80b he -> 745f36269f740ab7dd701a9b4788326fb01cf80b hi-IN -> 745f36269f740ab7dd701a9b4788326fb01cf80b hr -> 745f36269f740ab7dd701a9b4788326fb01cf80b hsb -> 745f36269f740ab7dd701a9b4788326fb01cf80b hu -> 745f36269f740ab7dd701a9b4788326fb01cf80b hy-AM -> 745f36269f740ab7dd701a9b4788326fb01cf80b ia -> 745f36269f740ab7dd701a9b4788326fb01cf80b id -> 745f36269f740ab7dd701a9b4788326fb01cf80b is -> 745f36269f740ab7dd701a9b4788326fb01cf80b it -> 745f36269f740ab7dd701a9b4788326fb01cf80b ja -> 745f36269f740ab7dd701a9b4788326fb01cf80b ka -> 745f36269f740ab7dd701a9b4788326fb01cf80b kab -> 745f36269f740ab7dd701a9b4788326fb01cf80b kk -> 745f36269f740ab7dd701a9b4788326fb01cf80b km -> 745f36269f740ab7dd701a9b4788326fb01cf80b kn -> 745f36269f740ab7dd701a9b4788326fb01cf80b ko -> 745f36269f740ab7dd701a9b4788326fb01cf80b lij -> 745f36269f740ab7dd701a9b4788326fb01cf80b lo -> 745f36269f740ab7dd701a9b4788326fb01cf80b lt -> 745f36269f740ab7dd701a9b4788326fb01cf80b ltg -> 745f36269f740ab7dd701a9b4788326fb01cf80b lv -> 745f36269f740ab7dd701a9b4788326fb01cf80b meh -> 745f36269f740ab7dd701a9b4788326fb01cf80b mix -> 745f36269f740ab7dd701a9b4788326fb01cf80b ml -> 745f36269f740ab7dd701a9b4788326fb01cf80b mr -> 745f36269f740ab7dd701a9b4788326fb01cf80b ms -> 745f36269f740ab7dd701a9b4788326fb01cf80b my -> 745f36269f740ab7dd701a9b4788326fb01cf80b nb-NO -> 745f36269f740ab7dd701a9b4788326fb01cf80b ne-NP -> 745f36269f740ab7dd701a9b4788326fb01cf80b nl -> 745f36269f740ab7dd701a9b4788326fb01cf80b nn-NO -> 745f36269f740ab7dd701a9b4788326fb01cf80b oc -> 745f36269f740ab7dd701a9b4788326fb01cf80b pa-IN -> 745f36269f740ab7dd701a9b4788326fb01cf80b pl -> 745f36269f740ab7dd701a9b4788326fb01cf80b pt-BR -> 745f36269f740ab7dd701a9b4788326fb01cf80b pt-PT -> 745f36269f740ab7dd701a9b4788326fb01cf80b rm -> 745f36269f740ab7dd701a9b4788326fb01cf80b ro -> 745f36269f740ab7dd701a9b4788326fb01cf80b ru -> 745f36269f740ab7dd701a9b4788326fb01cf80b sk -> 745f36269f740ab7dd701a9b4788326fb01cf80b sl -> 745f36269f740ab7dd701a9b4788326fb01cf80b son -> 745f36269f740ab7dd701a9b4788326fb01cf80b sq -> 745f36269f740ab7dd701a9b4788326fb01cf80b sr -> 745f36269f740ab7dd701a9b4788326fb01cf80b sv-SE -> 745f36269f740ab7dd701a9b4788326fb01cf80b ta -> 745f36269f740ab7dd701a9b4788326fb01cf80b te -> 745f36269f740ab7dd701a9b4788326fb01cf80b th -> 745f36269f740ab7dd701a9b4788326fb01cf80b tl -> 745f36269f740ab7dd701a9b4788326fb01cf80b tr -> 745f36269f740ab7dd701a9b4788326fb01cf80b trs -> 745f36269f740ab7dd701a9b4788326fb01cf80b uk -> 745f36269f740ab7dd701a9b4788326fb01cf80b ur -> 745f36269f740ab7dd701a9b4788326fb01cf80b uz -> 745f36269f740ab7dd701a9b4788326fb01cf80b vi -> 745f36269f740ab7dd701a9b4788326fb01cf80b wo -> 745f36269f740ab7dd701a9b4788326fb01cf80b xh -> 745f36269f740ab7dd701a9b4788326fb01cf80b zam -> 745f36269f740ab7dd701a9b4788326fb01cf80b zh-CN -> 745f36269f740ab7dd701a9b4788326fb01cf80b zh-TW -> 745f36269f740ab7dd701a9b4788326fb01cf80b
…ition. r=arai This refactors the entry point code in `BytecodeRangeWithPosition`: * Use an enum instead of two booleans. * Move code into `updatePosition` instead of separate functions. * Add some assertions for prologue bytecode ops. This simplifies the next patch. Differential Revision: https://phabricator.services.mozilla.com/D271578
… return value for prologue bytecode ops. r=arai If the offset was in the prologue, `getOffsetMetadata` and `getOffsetLocation` were returning information for the first 'main' op instead. This could result in confusing stepping behavior in DevTools if the first main op is a valid stepping location, because the debugger would pause in the prologue. This patch adds a `SkipPrologueOps` argument to `BytecodeRangeWithPosition` and requires callers to specify whether they want to skip prologue ops. Differential Revision: https://phabricator.services.mozilla.com/D271579
…,avandolder Differential Revision: https://phabricator.services.mozilla.com/D271604
…. r=adw,gregtatum,urlbar-reviewers Differential Revision: https://phabricator.services.mozilla.com/D271580
…viewers,nchevobbe,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D271223
…MOZ_RUNINIT r=emilio,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D271388
… r=emilio Differential Revision: https://phabricator.services.mozilla.com/D271019
…=ahal Differential Revision: https://phabricator.services.mozilla.com/D271614
…anager. r=extension-reviewers,zeid,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D271648
… new search bar widget. r=mbeier,willdurand Differential Revision: https://phabricator.services.mozilla.com/D271589
…theme-reviewers,adw,emilio Differential Revision: https://phabricator.services.mozilla.com/D271101
…p to 47a5db1f553ccabbe31020cc1b26a3f2dc5ff3a4 r=release-managers,pascalc Differential Revision: https://phabricator.services.mozilla.com/D271761
…ons-reviewers,desktop-theme-reviewers,gregtatum,dao This patch removes the "BETA" label from the FullPageTranslationsPanel and SelectTranslationsPanel in Firefox Desktop. Differential Revision: https://phabricator.services.mozilla.com/D271426
…ons-reviewers,android-reviewers,ohall This patch removes the "BETA" label from the full-page Translations Android UI. Differential Revision: https://phabricator.services.mozilla.com/D271427
…=android-reviewers,mcarare Differential Revision: https://phabricator.services.mozilla.com/D271678
…r=android-reviewers,mcarare w: This class is not recommended for use in Kotlin. Use 'kotlin.Any' instead. Differential Revision: https://phabricator.services.mozilla.com/D271680
… race with the new function r=win-reviewers,yjuglaret Differential Revision: https://phabricator.services.mozilla.com/D270721
…sureBufferSpace in the tokenizer. r=farre Differential Revision: https://phabricator.services.mozilla.com/D271752
…having a fix. r=aryx Differential Revision: https://phabricator.services.mozilla.com/D271732
…ent failures. r=intermittent-reviewers,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D271448
…ermittent-reviewers,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D271375
…rs,gstoll
When building with C++ for aarch64 windows, we get:
/builds/worker/workspace/obj-build/dist/include/mozilla/interceptor/Arm64.h(200,45): error: expected ';' after expression
200 | Trampoline<typename TrampPoolT::MMPolicyT> veneer(
| ^
/builds/worker/workspace/obj-build/dist/include/mozilla/interceptor/Arm64.h(200,3): error: use of undeclared identifier 'Trampoline'
200 | Trampoline<typename TrampPoolT::MMPolicyT> veneer(
| ^
/builds/worker/workspace/obj-build/dist/include/mozilla/interceptor/Arm64.h(204,3): error: use of undeclared identifier 'veneer'
204 | veneer.WriteEncodedPointer(nullptr);
| ^
/builds/worker/workspace/obj-build/dist/include/mozilla/interceptor/Arm64.h(205,3): error: use of undeclared identifier 'veneer'
205 | veneer.WriteEncodedPointer(aPrimaryTramp);
| ^
/builds/worker/workspace/obj-build/dist/include/mozilla/interceptor/Arm64.h(207,3): error: use of undeclared identifier 'veneer'
207 | veneer.StartExecutableCode();
| ^
This seems like a missing include on a function that gets instantiated
or type-checked more eagerly with C++20.
Fix it by including the relevant file.
Differential Revision: https://phabricator.services.mozilla.com/D271777
…n-reviewers,gstoll This already warns with clangd but somehow turns into a -Werror when switching to C++20. Differential Revision: https://phabricator.services.mozilla.com/D271676
…y r=tabbrowser-reviewers,desktop-theme-reviewers,kcochrane Differential Revision: https://phabricator.services.mozilla.com/D271620
…-reviewers,gstoll" for causing build bustages in Trampoline.h. This reverts commit 01c5113.
…r=android-reviewers,007 - Fixed the incorrect values for the M3 private color tokens in colors.xml - "android:colorBackground" will now use the correct private background color for the recent app preview. https://searchfox.org/firefox-main/rev/cb52781342cc905eda923d009fc0b678f3a8c8c6/mobile/android/fenix/app/src/main/res/values/styles.xml#355 Figma: https://www.figma.com/design/MjufE1X5fvkxZ0YneX4kRd/Android-Library--2025-?node-id=64745-6585&m=dev Differential Revision: https://phabricator.services.mozilla.com/D271353
…ESERVED_WRAPPER r=necko-reviewers,kershaw The absence of NS_IMPL_CYCLE_COLLECTION_UNLINK_PRESERVED_WRAPPER meant that even when GCd, the WebTransport object was still retrievable when calling weakref.deref(), but all its members were garbage collected already. This lead to a null deref when trying to access target.ready Differential Revision: https://phabricator.services.mozilla.com/D271550
…d code and not clicking on anything clickable. r=ayeddi Differential Revision: https://phabricator.services.mozilla.com/D271536
…andard8,mstriemer * Add Lit types in bundle-lit.sh that will get auto-generated with mach vendor command * Add "lit" that aliases to lit types in toolkit/content/widgets/vendor/lit.all.d.ts to avoid the super long path resolution Differential Revision: https://phabricator.services.mozilla.com/D259851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.