Automatic primary password for Firefox Enterprise #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beurdouche
approved these changes
Nov 10, 2025
Member
beurdouche
left a comment
beurdouche
left a comment
There was a problem hiding this comment.
Looks good ! Thanks GCP.
For the record a round of reviews happened prior to this PR.
gcp
force-pushed
the
enterprise-automatic-pp
branch
from
44cab99 to
e699901
Compare
beurdouche
approved these changes
Nov 10, 2025
gcp
commented
Nov 10, 2025
| const serverAddr = `http://localhost:${this._httpd.identity.primaryPort}`; | ||
| Services.prefs.setStringPref("browser.policies.server", serverAddr); | ||
| Services.prefs.setStringPref("browser.policies.access_token", "token"); | ||
| Services.prefs.setStringPref("enterprise.console.refresh_token", "token"); |
Contributor
Author
There was a problem hiding this comment.
@1rneh I suspect this test is currently broken? Didn't really know what to do here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #64, #124 and #113 and a fix to whitelist the pref.
Rebased to enterprise-main.