-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Description
interstitial
It seems that you ignore the call to useCustomClose(true) when the placement type is interstitial. I couldn't find this behavior written in the spec (MRAID v2.0 and v3.0).
Here is an example tag where you can reproduce the issue.
<script type='text/javascript'>
function useCustomClose() {
console.log('use custom close')
mraid.useCustomClose(true)
}
if (mraid.getState() === 'loading') {
mraid.addEventListener('ready', useCustomClose);
} else {
useCustomClose();
}
</script>You need to set the placement type to interstitial.
In the logs I can see:
14:33:29:901 INFO setting useCustomClose properties to true
14:33:29:900 INFO loading ad html
14:33:29:900 INFO ready event fired
14:33:29:900 INFO START READY SIGNAL, setting state to default
[...]
inline
I also noticed a similar issue with the inline placement type. If you don't provide a custom close, the container should its own custom close. This behavior isn't written in the spec (MRAID v2.0 and v3.0).
<script type='text/javascript'>
function useCustomClose() {
console.log('dont use custom close')
mraid.useCustomClose(false)
}
if (mraid.getState() === 'loading') {
mraid.addEventListener('ready', useCustomClose);
} else {
useCustomClose();
}
</script>Logs:
14:36:57:142 INFO setting useCustomClose properties to false
14:36:57:141 INFO loading ad html
14:36:57:141 INFO ready event fired
14:36:57:141 INFO START READY SIGNAL, setting state to default
14:36:57:140 INFO setting isViewable to true
14:36:57:140 INFO setting current position to {'width':293,'height':428,'y':13,'x':22}
14:36:57:140 INFO setting supports to [sms,tel,calendar,storePicture,inlineVideo,vpaid]
14:36:57:139 INFO setting orientationProperties to {'allowOrientationChange':true,'forceOrientation':none}
14:36:57:139 INFO merging resizeProperties with {'initialized':false,'validated':false,'width':0,'height':0,'customClosePosition':top-right,'offsetX':undefined,'offsetY':undefined,'allowOffscreen':true}
14:36:57:139 INFO merging expandProperties with {'width':320,'height':480,'useCustomClose':false,'isModal':false}
[...]
Metadata
Metadata
Assignees
Labels
No labels