Fix: Correct OEM condition check in getCore.js (Issue #1034) #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition on line 23 of getCore.js where the else if statement was checking for the same condition twice. Changed from checking if OEM is in [DEFAULT, LSTM_ONLY] to checking if it is NOT in that array (negated condition) to properly handle legacy model loading.
Fixed line 23 condition that was checking for the same OEM values twice.
Changed from: } else if ([OEM.DEFAULT, OEM.LSTM_ONLY].includes(oem)) {
Changed to: } else if (![OEM.DEFAULT, OEM.LSTM_ONLY].includes(oem)) {
This ensures legacy models (TESSERACT_ONLY, TESSERACT_LSTM_COMBINED) are loaded correctly when SIMD is not supported.
Fixes issue naptha#1034
Member
|
This does not pass the automated tests. As is noted in the readme, you should always confirm the test pass locally before opening a pull request. Additionally, I am closing as the substance of this change also appears to be incorrect. The new condition appears to be checking whether the LSTM-only model is requested ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dition on line 23 of getCore.js where the else if statement was checking for the same condition twice. Changed from checking if OEM is in [DEFAULT, LSTM_ONLY] to checking if it is NOT in that array (negated condition) to properly handle legacy model loading.
Fixed line 23 condition that was checking for the same OEM values twice. Changed from: } else if ([OEM.DEFAULT, OEM.LSTM_ONLY].includes(oem)) { Changed to: } else if (![OEM.DEFAULT, OEM.LSTM_ONLY].includes(oem)) {
This ensures legacy models (TESSERACT_ONLY, TESSERACT_LSTM_COMBINED) are loaded correctly when SIMD is not supported.
Fixes issue #1034