(2.14?) NRG: WAL must align with snapshot #7620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauriceVanVeen
changed the title
sciascid
reviewed
Dec 5, 2025
sciascid
reviewed
Dec 5, 2025
server/raft_test.go
Outdated
Comment on lines
3963
to
3968
| // Stop current node and restart it. | ||
| n.Stop() | ||
| n.WaitForStop() | ||
| // Restart. | ||
| n.Stop() | ||
| n.WaitForStop() |
Member
Author
There was a problem hiding this comment.
Ah, just left around due to copy pasting, resolved now.
MauriceVanVeen
force-pushed
the
maurice/nrg-wal-alignment
branch
from
b2c2b0a to
aaaa8ba
Compare
Member
neilalexander
left a comment
neilalexander
left a comment
There was a problem hiding this comment.
LGTM, just one naming thing.
server/raft_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestNRGTruncateLogWithMisingSnapshot(t *testing.T) { |
Member
There was a problem hiding this comment.
"Missing" instead of "Mising"
Signed-off-by: Maurice van Veen <[email protected]>
MauriceVanVeen
force-pushed
the
maurice/nrg-wal-alignment
branch
from
aaaa8ba to
6504333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Raft log can have three states:
We previously were not checking that these align, this would allow for the snapshot to be non-existent but the WAL to be way ahead or there to be a gap (somehow) between the snapshot and WAL itself. Both could lead to data loss.
Normally this shouldn't be an issue though, as these will always align. But, could potentially happen if a snapshot and the tail of the WAL were durably written, but somehow the head of the WAL was not.
Signed-off-by: Maurice van Veen [email protected]