Yet more GA fixes.

Author: ned14

.ci.cmake

@@ -21,7 +21,7 @@ endif()
 ctest_test(RETURN_VALUE retval)
 set(retval2 0)
 set(retval3 0)
-if(("$ENV{CXX}" MATCHES "g\\+\\+"))
+if(("$ENV{CXX}" MATCHES "clang"))
   ctest_build(TARGET _hl-asan)
   set(CTEST_CONFIGURATION_TYPE "asan")
   ctest_test(RETURN_VALUE retval2)

.github/workflows/unittests_linux.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        compiler: [clang++, g++, libc++]
+        compiler: [clang++-19, g++, libc++]
     env:
       NAME: Linux-${{ matrix.compiler }}
       CXX: ${{ matrix.compiler }}
@@ -34,6 +34,12 @@ jobs:
          sudo apt install clang-19 libc++-19-dev libc++abi-19-dev libomp-19-dev;
          export CMAKE_CONFIGURE_OPTIONS="-DCMAKE_TOOLCHAIN_FILE=../cmake/toolchain-linux-libc++.cmake";
          ctest -S .ci.cmake -VV -E noexcept --timeout 900 "-DCTEST_CONFIGURE_OPTIONS=$CMAKE_CONFIGURE_OPTIONS";
+       elif [ "${{ matrix.compiler }}" = "clang++-19" ]; then
+         wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add -;
+         sudo add-apt-repository "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main";
+         sudo apt update;
+         sudo apt install clang-19 libc++-19-dev libc++abi-19-dev libomp-19-dev;
+         ctest -S .ci.cmake -VV --timeout 900 "-DCTEST_CONFIGURE_OPTIONS=$CMAKE_CONFIGURE_OPTIONS";
        else
          ctest -S .ci.cmake -VV --timeout 900 "-DCTEST_CONFIGURE_OPTIONS=$CMAKE_CONFIGURE_OPTIONS";
        fi

doc/src/snippets/c_api.c

@@ -92,4 +92,4 @@ extern CXX_RESULT_SYSTEM(to_string_rettype) _Z9to_stringPcmi(char *buffer, size_
   ret.flags |= 1U;
   ret.value = len;
   return ret;
-}
+}

doc/src/snippets/constructors.cpp

@@ -1,5 +1,5 @@
 /* Example of Outcome used with constructors
-(C) 2017-2019 Niall Douglas <http://www.nedproductions.biz/> (5 commits)
+(C) 2017-2025 Niall Douglas <http://www.nedproductions.biz/> (5 commits)
 
 
 Licensed under the Apache License, Version 2.0 (the "License");
@@ -77,7 +77,11 @@ class file_handle
 
   // Moves but not copies permitted
   file_handle(const file_handle &) = delete;
-  file_handle(file_handle &&o) noexcept : _fd(o._fd) { o._fd = -1; }
+  file_handle(file_handle &&o) noexcept
+      : _fd(o._fd)
+  {
+    o._fd = -1;
+  }
   file_handle &operator=(const file_handle &) = delete;
   file_handle &operator=(file_handle &&o) noexcept
   {
@@ -130,7 +134,7 @@ inline outcome::result<file_handle> file_handle::file(file_handle::path_type pat
   default:
     return std::errc::invalid_argument;
   }
-  ret._fd = ::open(path.u8string().c_str(), flags);
+  ret._fd = ::open((const char *) path.u8string().c_str(), flags);
   if(-1 == ret._fd)
   {
     // Note that if we bail out here, ~file_handle() will correctly not call ::close()