feat: cch persistence #898
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add StoreWithPubSub to emit store update events. It uses ractor OutputPort for pub-sub. This is a rework of StoreWithHooks in nervosnetwork#511 - Use decorator pattern to add additional features on Store - Minimize the interface change that original codes relying on Store traits dot not need to change. - Avoid using an Actor to fetch extra data asynchronously. This resolves the issue mentioned in nervosnetwork#615 (comment) . The channel actor cleans preimage on success payment automatically. Thus we may fail to get the preimage when settling the cch payment in the BTC end.
doitian
force-pushed
the
feature/cch-persistence
branch
from
dbb0121 to
f7b27ae
Compare
Merge SendBTCOrder and ReceiveBTCOrder into CchOrder to simplify persistence. Add a order status to mark that the outgoing payment succeeds and preimage is obtained. Ensure the preimage is stored in case to retry settling the incoming payment.
Load orders from database and resume the workflow.
doitian
force-pushed
the
feature/cch-persistence
branch
from
f7b27ae to
ac35142
Compare
This was referenced Nov 4, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #615
A rework of #522
The PR can be reviewed by commits: