Skip to content

Make sh exec into explicit to avoid valkey getting SIGKILLed #1552

@ypid-work

Description

@ypid-work

Desired Behavior

- sh
- -c # this is to evaluate the $REDIS_PASSWORD from the env
- valkey-server --appendonly yes --requirepass $$REDIS_PASSWORD ## $$ because of docker-compose

should be changed to exec valkey-server (all occurrences).

Contrast to Current Behavior

It is currently implicit (da)sh behavior that could stop working if someone not aware changes the inline shell script.

Required Changes

No response

Discussion: Benefits and Drawbacks

I have posted more details here: valkey-io/valkey-container#71 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions