Merge pull request #16047 from nextcloud/use-snackbar-instead-of-toast

alperozturk96 · web-flow · commit d07879515769 · 2025-12-04T08:58:55.000+01:00
feat: use snackbar instead of toast
diff --git a/app/src/main/java/com/nextcloud/ui/fileactions/FileActionsBottomSheet.kt b/app/src/main/java/com/nextcloud/ui/fileactions/FileActionsBottomSheet.kt
@@ -16,7 +16,6 @@ import android.text.style.StyleSpan
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import android.widget.Toast
 import androidx.annotation.IdRes
 import androidx.appcompat.content.res.AppCompatResources
 import androidx.core.os.bundleOf
@@ -123,8 +122,8 @@ class FileActionsBottomSheet :
 
             FileActionsViewModel.UiState.Loading -> {}
             FileActionsViewModel.UiState.Error -> {
-                context?.let {
-                    Toast.makeText(it, R.string.error_file_actions, Toast.LENGTH_SHORT).show()
+                activity?.let {
+                    DisplayUtils.showSnackMessage(it, R.string.error_file_actions)
                 }
                 dismissAllowingStateLoss()
             }
diff --git a/app/src/main/java/com/nextcloud/ui/trashbinFileActions/TrashbinFileActionsBottomSheet.kt b/app/src/main/java/com/nextcloud/ui/trashbinFileActions/TrashbinFileActionsBottomSheet.kt
@@ -10,7 +10,6 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import android.widget.Toast
 import androidx.annotation.IdRes
 import androidx.appcompat.content.res.AppCompatResources
 import androidx.core.os.bundleOf
@@ -108,8 +107,8 @@ class TrashbinFileActionsBottomSheet :
 
             TrashbinFileActionsViewModel.UiState.Loading -> {}
             TrashbinFileActionsViewModel.UiState.Error -> {
-                context?.let {
-                    Toast.makeText(it, R.string.error_file_actions, Toast.LENGTH_SHORT).show()
+                activity?.let {
+                    DisplayUtils.showSnackMessage(it, R.string.error_file_actions)
                 }
                 dismissAllowingStateLoss()
             }
diff --git a/app/src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java b/app/src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java
@@ -44,7 +44,6 @@
 import android.widget.LinearLayout;
 import android.widget.TextView;
 import android.widget.TextView.OnEditorActionListener;
-import android.widget.Toast;
 
 import com.blikoon.qrcodescanner.QrCodeActivity;
 import com.google.android.material.button.MaterialButton;
@@ -859,7 +858,7 @@ protected void onNewIntent(Intent intent) {
         if (data != null && data.toString().startsWith(getString(R.string.login_data_own_scheme))) {
             if (!MDMConfig.INSTANCE.multiAccountSupport(this) &&
                 accountManager.getAccounts().length == 1) {
-                Toast.makeText(this, R.string.no_mutliple_accounts_allowed, Toast.LENGTH_LONG).show();
+                DisplayUtils.showSnackMessage(this, R.string.no_mutliple_accounts_allowed);
                 finish();
                 return;
             } else {
@@ -1307,18 +1306,23 @@ private void updateAuthStatusIconAndText(RemoteOperationResult result) {
             case ACCOUNT_NOT_NEW:
                 mAuthStatusText = getString(R.string.auth_account_not_new);
                 if (!showWebViewLoginUrl) {
-                    DisplayUtils.showErrorAndFinishActivity(this, mAuthStatusText);
+                    showErrorAndFinishActivity();
                 }
                 break;
             case UNHANDLED_HTTP_CODE:
             default:
                 mAuthStatusText = ErrorMessageAdapter.getErrorCauseMessage(result, null, getResources());
                 if (!showWebViewLoginUrl) {
-                    DisplayUtils.showErrorAndFinishActivity(this, mAuthStatusText);
+                    showErrorAndFinishActivity();
                 }
         }
     }
 
+    private void showErrorAndFinishActivity() {
+        DisplayUtils.showSnackMessage(this, mAuthStatusText);
+        finish();
+    }
+
     private void updateStatusIconFailUserName(int failedStatusText) {
         mAuthStatusIcon = R.drawable.ic_alert;
         mAuthStatusText = getResources().getString(failedStatusText);
@@ -1588,7 +1592,7 @@ private void startQRScanner() {
 
                 if (!MDMConfig.INSTANCE.multiAccountSupport(this) &&
                     accountManager.getAccounts().length == 1) {
-                    Toast.makeText(this, R.string.no_mutliple_accounts_allowed, Toast.LENGTH_LONG).show();
+                    DisplayUtils.showSnackMessage(this, R.string.no_mutliple_accounts_allowed);
                 } else {
                     parseAndLoginFromWebView(resultData);
                 }
diff --git a/app/src/main/java/com/owncloud/android/authentication/DeepLinkLoginActivity.kt b/app/src/main/java/com/owncloud/android/authentication/DeepLinkLoginActivity.kt
@@ -9,10 +9,10 @@ package com.owncloud.android.authentication
 
 import android.os.Bundle
 import android.widget.TextView
-import android.widget.Toast
 import com.nextcloud.client.di.Injectable
 import com.nextcloud.utils.mdm.MDMConfig
 import com.owncloud.android.R
+import com.owncloud.android.utils.DisplayUtils
 
 class DeepLinkLoginActivity :
     AuthenticatorActivity(),
@@ -21,7 +21,7 @@ class DeepLinkLoginActivity :
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         if (!MDMConfig.multiAccountSupport(this) && accountManager.accounts.size == 1) {
-            Toast.makeText(this, R.string.no_mutliple_accounts_allowed, Toast.LENGTH_LONG).show()
+            DisplayUtils.showSnackMessage(this, R.string.no_mutliple_accounts_allowed)
             return
         }
 
@@ -37,8 +37,8 @@ class DeepLinkLoginActivity :
                     loginUrlInfo.loginName,
                     loginUrlInfo.server
                 )
-            } catch (e: IllegalArgumentException) {
-                Toast.makeText(this, R.string.direct_login_failed, Toast.LENGTH_LONG).show()
+            } catch (_: IllegalArgumentException) {
+                DisplayUtils.showSnackMessage(this, R.string.direct_login_failed)
             }
         }
     }
diff --git a/app/src/main/java/com/owncloud/android/ui/activity/ConflictsResolveActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/ConflictsResolveActivity.kt
@@ -14,7 +14,6 @@ import android.app.NotificationManager
 import android.content.Context
 import android.content.Intent
 import android.os.Bundle
-import android.widget.Toast
 import androidx.fragment.app.FragmentTransaction
 import androidx.lifecycle.lifecycleScope
 import com.nextcloud.client.account.User
@@ -41,6 +40,7 @@ import com.owncloud.android.lib.resources.files.model.RemoteFile
 import com.owncloud.android.ui.dialog.ConflictsResolveDialog
 import com.owncloud.android.ui.dialog.ConflictsResolveDialog.Decision
 import com.owncloud.android.ui.dialog.ConflictsResolveDialog.OnConflictDecisionMadeListener
+import com.owncloud.android.utils.DisplayUtils
 import com.owncloud.android.utils.FileStorageUtils
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
@@ -356,7 +356,7 @@ class ConflictsResolveActivity :
     private fun showErrorAndFinish(code: Int? = null) {
         val message = parseErrorMessage(code)
         lifecycleScope.launch(Dispatchers.Main) {
-            Toast.makeText(this@ConflictsResolveActivity, message, Toast.LENGTH_LONG).show()
+            DisplayUtils.showSnackMessage(this@ConflictsResolveActivity, message)
             finish()
         }
     }
diff --git a/app/src/main/java/com/owncloud/android/ui/activity/EditorWebView.java b/app/src/main/java/com/owncloud/android/ui/activity/EditorWebView.java
@@ -23,7 +23,6 @@
 import android.webkit.ValueCallback;
 import android.webkit.WebChromeClient;
 import android.webkit.WebView;
-import android.widget.Toast;
 
 import com.google.android.material.snackbar.Snackbar;
 import com.nextcloud.client.account.User;
@@ -95,8 +94,7 @@ public void onUrlLoaded(String loadedUrl) {
                 }
             }, 10 * 1000);
         } else {
-            Toast.makeText(getApplicationContext(),
-                           R.string.richdocuments_failed_to_load_document, Toast.LENGTH_LONG).show();
+            DisplayUtils.showSnackMessage(this,R.string.richdocuments_failed_to_load_document);
             finish();
         }
     }
@@ -152,7 +150,7 @@ public boolean onShowFileChooser(WebView webView, ValueCallback<Uri[]> filePathC
                     activity.startActivityForResult(intent, REQUEST_LOCAL_FILE);
                 } catch (ActivityNotFoundException e) {
                     uploadMessage = null;
-                    Toast.makeText(getBaseContext(), "Cannot open file chooser", Toast.LENGTH_LONG).show();
+                    DisplayUtils.showSnackMessage(EditorWebView.this, R.string.editor_web_view_cannot_open_file);
                     return false;
                 }
 
@@ -163,8 +161,7 @@ public boolean onShowFileChooser(WebView webView, ValueCallback<Uri[]> filePathC
         setFile(IntentExtensionsKt.getParcelableArgument(getIntent(), ExternalSiteWebView.EXTRA_FILE, OCFile.class));
 
         if (getFile() == null) {
-            Toast.makeText(getApplicationContext(),
-                           R.string.richdocuments_failed_to_load_document, Toast.LENGTH_LONG).show();
+            DisplayUtils.showSnackMessage(this, R.string.richdocuments_failed_to_load_document);
             finish();
         }
 
diff --git a/app/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java b/app/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java
@@ -43,7 +43,6 @@
 import android.widget.ImageView;
 import android.widget.Spinner;
 import android.widget.TextView;
-import android.widget.Toast;
 
 import com.google.android.material.button.MaterialButton;
 import com.google.android.material.dialog.MaterialAlertDialogBuilder;
@@ -247,10 +246,9 @@ protected void onStart() {
         super.onStart();
 
         if (mAccountManager.getAccountsByType(MainApp.getAccountType(this)).length == 0) {
-            Toast.makeText(this,
-                           String.format(getString(R.string.uploader_wrn_no_account_text),
-                                         getString(R.string.app_name)),
-                           Toast.LENGTH_LONG).show();
+            final var message = String.format(getString(R.string.uploader_wrn_no_account_text),
+                                              getString(R.string.app_name));
+            DisplayUtils.showSnackMessage(this, message);
             return;
         }
 
diff --git a/app/src/main/java/com/owncloud/android/ui/activity/RequestCredentialsActivity.java b/app/src/main/java/com/owncloud/android/ui/activity/RequestCredentialsActivity.java
@@ -16,7 +16,6 @@
 import android.content.Intent;
 import android.os.Bundle;
 import android.os.SystemClock;
-import android.widget.Toast;
 
 import com.nextcloud.client.preferences.AppPreferencesImpl;
 import com.owncloud.android.R;
@@ -55,7 +54,7 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
             } else if (resultCode == Activity.RESULT_CANCELED) {
                 finishWithResult(KEY_CHECK_RESULT_CANCEL);
             } else {
-                Toast.makeText(this, R.string.default_credentials_wrong, Toast.LENGTH_SHORT).show();
+                DisplayUtils.showSnackMessage(this, R.string.default_credentials_wrong);
                 requestCredentials();
             }
         }
diff --git a/app/src/main/java/com/owncloud/android/ui/activity/SetupEncryptionActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/SetupEncryptionActivity.kt
@@ -9,12 +9,12 @@ package com.owncloud.android.ui.activity
 
 import android.content.Intent
 import android.os.Bundle
-import android.widget.Toast
 import androidx.appcompat.app.AppCompatActivity
 import com.nextcloud.client.account.User
 import com.nextcloud.utils.extensions.getParcelableArgument
 import com.owncloud.android.R
 import com.owncloud.android.ui.dialog.setupEncryption.SetupEncryptionDialogFragment
+import com.owncloud.android.utils.DisplayUtils
 
 class SetupEncryptionActivity : AppCompatActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
@@ -23,7 +23,7 @@ class SetupEncryptionActivity : AppCompatActivity() {
         val user = intent?.getParcelableArgument("EXTRA_USER", User::class.java)
 
         if (user == null) {
-            Toast.makeText(this, getString(R.string.error_showing_encryption_dialog), Toast.LENGTH_LONG).show()
+            DisplayUtils.showSnackMessage(this, R.string.error_showing_encryption_dialog)
             finish()
         }
 
diff --git a/app/src/main/java/com/owncloud/android/ui/activity/TextEditorWebView.kt b/app/src/main/java/com/owncloud/android/ui/activity/TextEditorWebView.kt
@@ -8,7 +8,6 @@
 package com.owncloud.android.ui.activity
 
 import android.annotation.SuppressLint
-import android.widget.Toast
 import androidx.core.net.toUri
 import androidx.webkit.WebSettingsCompat
 import androidx.webkit.WebViewFeature
@@ -18,6 +17,7 @@ import com.nextcloud.client.device.DeviceInfo
 import com.nextcloud.utils.EditorUtils
 import com.owncloud.android.R
 import com.owncloud.android.ui.asynctasks.TextEditorLoadUrlTask
+import com.owncloud.android.utils.DisplayUtils
 import com.owncloud.android.utils.theme.ThemeUtils
 import javax.inject.Inject
 
@@ -39,7 +39,7 @@ class TextEditorWebView : EditorWebView() {
         super.postOnCreate()
 
         if (!user.isPresent) {
-            Toast.makeText(this, getString(R.string.failed_to_start_editor), Toast.LENGTH_LONG).show()
+            DisplayUtils.showSnackMessage(this, R.string.failed_to_start_editor)
             finish()
         }
 
diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/ConflictsResolveDialog.kt b/app/src/main/java/com/owncloud/android/ui/dialog/ConflictsResolveDialog.kt
@@ -11,7 +11,6 @@ import android.content.Context
 import android.content.DialogInterface
 import android.os.Bundle
 import android.view.View
-import android.widget.Toast
 import androidx.appcompat.app.AlertDialog
 import androidx.appcompat.app.AppCompatActivity
 import androidx.fragment.app.DialogFragment
@@ -79,7 +78,7 @@ class ConflictsResolveDialog :
 
         try {
             listener = context as OnConflictDecisionMadeListener
-        } catch (e: ClassCastException) {
+        } catch (_: ClassCastException) {
             throw ClassCastException("Activity of this dialog must implement OnConflictDecisionMadeListener")
         }
     }
@@ -90,7 +89,9 @@ class ConflictsResolveDialog :
         val alertDialog = dialog as AlertDialog?
 
         if (alertDialog == null) {
-            Toast.makeText(context, "Failed to create conflict dialog", Toast.LENGTH_LONG).show()
+            activity?.let {
+                DisplayUtils.showSnackMessage(it, R.string.failed_to_create_conflict_dialog)
+            }
             return
         }
 
@@ -116,7 +117,9 @@ class ConflictsResolveDialog :
             rightDataFile = bundle.getParcelableArgument(ARG_RIGHT_FILE, OCFile::class.java)
             user = bundle.getParcelableArgument(ARG_USER, User::class.java)
         } else {
-            Toast.makeText(context, "Failed to create conflict dialog", Toast.LENGTH_LONG).show()
+            activity?.let {
+                DisplayUtils.showSnackMessage(it, R.string.failed_to_create_conflict_dialog)
+            }
         }
     }
 
diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/SendFilesDialog.kt b/app/src/main/java/com/owncloud/android/ui/dialog/SendFilesDialog.kt
@@ -16,7 +16,6 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import android.widget.Toast
 import androidx.recyclerview.widget.GridLayoutManager
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment
 import com.nextcloud.android.common.ui.theme.utils.ColorRole
@@ -27,6 +26,7 @@ import com.owncloud.android.databinding.SendFilesFragmentBinding
 import com.owncloud.android.datamodel.OCFile
 import com.owncloud.android.ui.adapter.SendButtonAdapter
 import com.owncloud.android.ui.components.SendButtonData
+import com.owncloud.android.utils.DisplayUtils
 import com.owncloud.android.utils.theme.ViewThemeUtils
 import javax.inject.Inject
 
@@ -68,7 +68,9 @@ class SendFilesDialog :
         val matches = requireActivity().packageManager.queryIntentActivities(sendIntent, 0)
 
         if (matches.isEmpty()) {
-            Toast.makeText(context, R.string.no_send_app, Toast.LENGTH_SHORT).show()
+            activity?.let {
+                DisplayUtils.showSnackMessage(it, R.string.no_send_app)
+            }
             dismiss()
             return
         }
diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java b/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java
@@ -33,7 +33,6 @@
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.AbsListView;
-import android.widget.Toast;
 
 import com.google.android.material.bottomsheet.BottomSheetBehavior;
 import com.google.android.material.dialog.MaterialAlertDialogBuilder;
@@ -587,10 +586,7 @@ public void scanDocUpload() {
         } else {
             Log.w(TAG, "scanDocUpload: Failed to start doc scanning, fileDisplayActivity=" + fileDisplayActivity +
                 ", currentFile=" + currentFile);
-            Toast.makeText(getContext(),
-                           getString(R.string.error_starting_doc_scan),
-                           Toast.LENGTH_SHORT)
-                .show();
+            DisplayUtils.showSnackMessage(this, R.string.error_starting_doc_scan);
         }
     }
 
diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupFragment.kt
@@ -20,7 +20,6 @@ import android.view.View
 import android.view.ViewGroup
 import android.widget.CompoundButton
 import android.widget.DatePicker
-import android.widget.Toast
 import androidx.core.app.ActivityCompat
 import androidx.lifecycle.lifecycleScope
 import com.nextcloud.client.account.User
@@ -521,7 +520,9 @@ class BackupFragment :
     private fun openDate(savedDate: Calendar?) {
         val contactsPreferenceActivity = activity as ContactsPreferenceActivity?
         if (contactsPreferenceActivity == null) {
-            Toast.makeText(context, getString(R.string.error_choosing_date), Toast.LENGTH_LONG).show()
+            activity?.let {
+                DisplayUtils.showSnackMessage(it, R.string.error_choosing_date)
+            }
             return
         }
 
@@ -583,7 +584,9 @@ class BackupFragment :
     override fun onDateSet(view: DatePicker, year: Int, month: Int, dayOfMonth: Int) {
         val contactsPreferenceActivity = activity as ContactsPreferenceActivity?
         if (contactsPreferenceActivity == null) {
-            Toast.makeText(context, getString(R.string.error_choosing_date), Toast.LENGTH_LONG).show()
+            activity?.let {
+                DisplayUtils.showSnackMessage(it, R.string.error_choosing_date)
+            }
             return
         }
 
diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupListFragment.java b/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupListFragment.java
diff --git a/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinActivity.kt b/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinActivity.kt
diff --git a/app/src/main/java/com/owncloud/android/utils/DisplayUtils.java b/app/src/main/java/com/owncloud/android/utils/DisplayUtils.java
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml

Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,10 @@ package com.owncloud.android.authentication`
`9`	`9`
`10`	`10`	`import android.os.Bundle`
`11`	`11`	`import android.widget.TextView`
`12`		`-import android.widget.Toast`
`13`	`12`	`import com.nextcloud.client.di.Injectable`
`14`	`13`	`import com.nextcloud.utils.mdm.MDMConfig`
`15`	`14`	`import com.owncloud.android.R`
	`15`	`+import com.owncloud.android.utils.DisplayUtils`
`16`	`16`
`17`	`17`	`class DeepLinkLoginActivity :`
`18`	`18`	`AuthenticatorActivity(),`
`@@ -21,7 +21,7 @@ class DeepLinkLoginActivity :`
`21`	`21`	`override fun onCreate(savedInstanceState: Bundle?) {`
`22`	`22`	`super.onCreate(savedInstanceState)`
`23`	`23`	`if (!MDMConfig.multiAccountSupport(this) && accountManager.accounts.size == 1) {`
`24`		`- Toast.makeText(this, R.string.no_mutliple_accounts_allowed, Toast.LENGTH_LONG).show()`
	`24`	`+ DisplayUtils.showSnackMessage(this, R.string.no_mutliple_accounts_allowed)`
`25`	`25`	`return`
`26`	`26`	`}`
`27`	`27`
`@@ -37,8 +37,8 @@ class DeepLinkLoginActivity :`
`37`	`37`	`loginUrlInfo.loginName,`
`38`	`38`	`loginUrlInfo.server`
`39`	`39`	`)`
`40`		`- } catch (e: IllegalArgumentException) {`
`41`		`- Toast.makeText(this, R.string.direct_login_failed, Toast.LENGTH_LONG).show()`
	`40`	`+ } catch (_: IllegalArgumentException) {`
	`41`	`+ DisplayUtils.showSnackMessage(this, R.string.direct_login_failed)`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`	`}`