ui fixes

Signed-off-by: alperozturk <[email protected]>

Author: alperozturk96

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt

@@ -198,7 +198,6 @@ class FileDetailsSharingProcessFragment :
         setCheckboxStates()
         themeView()
         setVisibilitiesOfShareOption()
-        toggleNextButtonAvailability(isAnySharePermissionChecked())
         logShareInfo()
     }
 
@@ -496,11 +495,14 @@ class FileDetailsSharingProcessFragment :
             return
         }
 
-        val currentLimit = share?.remainingDownloadLimit() ?: return
+        // user can set download limit thus no need to rely on current limit to show download limit
+        showFileDownloadLimitInput(true)
         binding.shareProcessSetDownloadLimitSwitch.visibility = View.VISIBLE
+        binding.shareProcessSetDownloadLimitInput.visibility = View.VISIBLE
+
+        val currentLimit = share?.remainingDownloadLimit() ?: return
         if (currentLimit > 0) {
             binding.shareProcessSetDownloadLimitSwitch.isChecked = true
-            showFileDownloadLimitInput(true)
             binding.shareProcessSetDownloadLimitInput.setText(currentLimit.toString())
         }
     }
@@ -587,7 +589,6 @@ class FileDetailsSharingProcessFragment :
 
                 val isCustomPermissionSelected = (optionId == R.id.custom_permission_radio_button)
                 customPermissionLayout.setVisibilityWithAnimation(isCustomPermissionSelected)
-                toggleNextButtonAvailability(true)
             }
             // endregion
         }
@@ -612,13 +613,6 @@ class FileDetailsSharingProcessFragment :
                 )
     }
 
-    private fun toggleNextButtonAvailability(value: Boolean) {
-        binding.run {
-            shareProcessBtnNext.isEnabled = value
-            shareProcessBtnNext.isClickable = value
-        }
-    }
-
     @Suppress("NestedBlockDepth")
     private fun setCheckboxStates() {
         val currentPermissions = share?.permissions ?: permission
@@ -676,7 +670,6 @@ class FileDetailsSharingProcessFragment :
 
     private fun togglePermission(isChecked: Boolean, permissionFlag: Int) {
         permission = SharePermissionManager.togglePermission(isChecked, permission, permissionFlag)
-        toggleNextButtonAvailability(true)
     }
 
     private fun showExpirationDateDialog(chosenDateInMillis: Long = chosenExpDateInMills) {
@@ -781,14 +774,6 @@ class FileDetailsSharingProcessFragment :
             return
         }
 
-        if (!isSharePermissionChecked() && !isCustomPermissionSelectedAndAnyCustomPermissionTypeChecked()) {
-            DisplayUtils.showSnackMessage(
-                binding.root,
-                R.string.file_details_sharing_fragment_custom_permission_not_selected
-            )
-            return
-        }
-
         // if modifying existing share information then execute the process
         if (share != null) {
             updateShare()

app/src/main/res/values/strings.xml

@@ -1448,7 +1448,6 @@
     <string name="sync_duplication">Sync duplication</string>
     <string name="server_not_reachable">Could not load content</string>
     <string name="server_not_reachable_content">The device is likely not connected to the internet</string>
-    <string name="file_details_sharing_fragment_custom_permission_not_selected">Please select custom permission</string>
     <string name="unknown">Unknown</string>
     <string name="upload_missing_storage_permission_title">Upload Stopped – Storage Permission Required</string>
     <string name="upload_missing_storage_permission_description">Your files cannot be uploaded without access to local storage. Tap to grant permission.</string>