fix: back press handling in settings activity #15949
Open
+6
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
Collaborator
Author
|
/backport to stable-3.34 |
Signed-off-by: alperozturk <[email protected]>
alperozturk96
commented
Nov 12, 2025
|
|
||
| @SuppressLint("GestureBackNavigation") | ||
| @Override | ||
| public void onBackPressed() { |
Collaborator
Author
There was a problem hiding this comment.
No need to override the back press behavior, since the back press will handle itself and display whatever is in the stack.
alperozturk96
commented
Nov 12, 2025
| contactsPreferenceActivity.finish() | ||
| } else { | ||
| val settingsIntent = Intent(context, SettingsActivity::class.java) | ||
| settingsIntent.flags = Intent.FLAG_ACTIVITY_SINGLE_TOP or Intent.FLAG_ACTIVITY_CLEAR_TOP |
Collaborator
Author
There was a problem hiding this comment.
Don't clear stack so that we can go back from SettingsActivity
alperozturk96
commented
Nov 12, 2025
| handleMnemonicRequest(data); | ||
| } else if (requestCode == ACTION_E2E && data != null && data.getBooleanExtra(SetupEncryptionDialogFragment.SUCCESS, false)) { | ||
| Intent i = new Intent(this, SettingsActivity.class); | ||
| i.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP); |
Collaborator
Author
There was a problem hiding this comment.
Don't clear stack so that we can go back from SettingsActivity
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15949.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes drawer menu highlighting and transition from
SettingsActivity.Old related PR: #15384