fix: event bus drawer activity

[alperozturk96]

• Tests written, or not not needed

Fixes

Exception in thread "main" java.lang.NoClassDefFoundError: Failed resolution of: Landroid/app/ComponentCaller;
    at java.lang.reflect.Executable.getParameterTypesInternal(Native Method)
    at java.lang.reflect.Method.getParameterTypes(Method.java:186)
    at org.greenrobot.eventbus.SubscriberMethodFinder.findUsingReflectionInSingleClass(SubscriberMethodFinder.java:173)
    at org.greenrobot.eventbus.SubscriberMethodFinder.findUsingInfo(SubscriberMethodFinder.java:88)
    at org.greenrobot.eventbus.SubscriberMethodFinder.findSubscriberMethods(SubscriberMethodFinder.java:64)
    at org.greenrobot.eventbus.EventBus.register(EventBus.java:150)
    at com.owncloud.android.ui.activity.DrawerActivity.onStart(DrawerActivity.java:1310)
    at com.owncloud.android.ui.activity.FileActivity.onStart(FileActivity.java:280)
    at com.owncloud.android.ui.activity.FileDisplayActivity.onStart(FileDisplayActivity.kt:2794)
    at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1601)
    at android.app.Activity.performStart(Activity.java:8790)
    at android.app.ActivityThread.handleStartActivity(ActivityThread.java:4056)
    at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:230)
    at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:210)
    at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:182)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:103)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2643)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loopOnce(Looper.java:257)
    at android.os.Looper.loop(Looper.java:368)
    at android.app.ActivityThread.main(ActivityThread.java:8839)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:572)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)
Caused by: Exception in thread "main" java.lang.ClassNotFoundException: android.app.ComponentCaller
    at java.lang.reflect.Executable.getParameterTypesInternal(Native Method)
    at java.lang.reflect.Method.getParameterTypes(Method.java:186)
    at org.greenrobot.eventbus.SubscriberMethodFinder.findUsingReflectionInSingleClass(SubscriberMethodFinder.java:173)
    at org.greenrobot.eventbus.SubscriberMethodFinder.findUsingInfo(SubscriberMethodFinder.java:88)
    at org.greenrobot.eventbus.SubscriberMethodFinder.findSubscriberMethods(SubscriberMethodFinder.java:64)
    at org.greenrobot.eventbus.EventBus.register(EventBus.java:150)
    at com.owncloud.android.ui.activity.DrawerActivity.onStart(DrawerActivity.java:1310)
    at com.owncloud.android.ui.activity.FileActivity.onStart(FileActivity.java:280)
    at com.owncloud.android.ui.activity.FileDisplayActivity.onStart(FileDisplayActivity.kt:2794)
    at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1601)
    at android.app.Activity.performStart(Activity.java:8790)
    at android.app.ActivityThread.handleStartActivity(ActivityThread.java:4056)
    at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:230)
    at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:210)
    at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:182)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:103)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2643)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loopOnce(Looper.java:257)
    at android.os.Looper.loop(Looper.java:368)
    at android.app.ActivityThread.main(ActivityThread.java:8839)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:572)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)

[alperozturk96]

/backport to stable-3.35

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	260	260
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	48	48
Security	18	18
Total	488	488

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16092.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[alperozturk96]

Failed screenshot tests (unrelated):

com.***.client.ActivitiesActivityIT > showActivities[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@258cad7, window-token=android.view.ViewRootImpl$W@258cad7, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} layoutInDisplayCutoutMode=always ty=BASE_APPLICATION wanim=0x10302f8
emulator-5554 - 9 Tests 1/116 completed. (0 skipped) (1 failed)
> Task :app:connectedGenericDebugAndroidTest
com.***.client.ActivitiesActivityIT > openDrawer[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@998b0fa, window-token=android.view.ViewRootImpl$W@998b0fa, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} layoutInDisplayCutoutMode=always ty=BASE_APPLICATION wanim=0x10302f8
emulator-5554 - 9 Tests 2/116 completed. (0 skipped) (2 failed)
> Task :app:connectedGenericDebugAndroidTest
com.***.client.ActivitiesActivityIT > empty[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@a08ba80, window-token=android.view.ViewRootImpl$W@a08ba80, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} layoutInDisplayCutoutMode=always ty=BASE_APPLICATION wanim=0x10302f8
emulator-5554 - 9 Tests 3/116 completed. (0 skipped) (3 failed)
> Task :app:connectedGenericDebugAndroidTest
com.***.client.ActivitiesActivityIT > error[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@abb6d91, window-token=android.view.ViewRootImpl$W@abb6d91, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} layoutInDisplayCutoutMode=always ty=BASE_APPLICATION wanim=0x10302f8
emulator-5554 - 9 Tests 4/116 completed. (0 skipped) (4 failed)
> Task :app:connectedGenericDebugAndroidTest
com.***.client.ActivitiesActivityIT > loading[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@7c65ce2, window-token=android.view.ViewRootImpl$W@7c65ce2, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} layoutInDisplayCutoutMode=always ty=BASE_APPLICATION wanim=0x10302f8
emulator-5554 - 9 Tests 6/116 completed. (0 skipped) (5 failed)
> Task :app:connectedGenericDebugAndroidTest
com.***.client.CommunityActivityIT > open[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@b6f5516, window-token=android.view.ViewRootImpl$W@b6f5516, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} layoutInDisplayCutoutMode=always ty=BASE_APPLICATION wanim=0x10302f8
com.***.client.FileDisplayActivityScreenshotIT > drawer[emulator-5554 - 9] FAILED 
	java.lang.SecurityException: Error granting runtime permission
	at android.app.UiAutomation.grantRuntimePermissionAsUser(UiAutomation.java:941)
com.***.client.FileDisplayActivityScreenshotIT > open[emulator-5554 - 9] FAILED 
	java.lang.SecurityException: Error granting runtime permission
	at android.app.UiAutomation.grantRuntimePermissionAsUser(UiAutomation.java:941)
com.***.client.FileDisplayActivityScreenshotIT > showMediaThenAllFiles[emulator-5554 - 9] FAILED 
	java.lang.SecurityException: Error granting runtime permission
	at android.app.UiAutomation.grantRuntimePermissionAsUser(UiAutomation.java:941)
emulator-5554 - 9 Tests 10/116 completed. (0 skipped) (9 failed)
> Task :app:connectedGenericDebugAndroidTest
com.***.client.FirstRunActivityIT > open[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@c71c9f2, window-token=android.view.ViewRootImpl$W@c71c9f2, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} layoutInDisplayCutoutMode=always ty=BASE_APPLICATION wanim=0x10302f8
emulator-5554 - 9 Tests 11/116 completed. (0 skipped) (10 failed)
> Task :app:connectedGenericDebugAndroidTest
com.***.client.SettingsActivityIT > showMnemonic_Error[emulator-5554 - 9] FAILED 
	androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:
	Root{application-window-token=android.view.ViewRootImpl$W@3d3d5a8, window-token=android.view.ViewRootImpl$W@3d3d5a8, has-window-focus=false, layout-params-type=1, layout-params-string={(0,0)(fillxfill) sim={forwardNavigation} ty=BASE_APPLICATION wanim=0x10302f8
emulator-5554 - 9 Tests 12/116 completed. (0 skipped) (11 failed)
> Task :app:connectedGenericDebugAndroidTest
	java.lang.SecurityException: Error granting runtime permission
	at android.app.UiAutomation.grantRuntimePermissionAsUser(UiAutomation.java:941)
com.owncloud.android.ui.preview.PreviewTextFileFragmentTest > displaySimpleTextFile[emulator-5554 - 9] FAILED 
	java.lang.SecurityException: Error granting runtime permission
	at android.app.UiAutomation.grantRuntimePermissionAsUser(UiAutomation.java:941)
emulator-5554 - 9 Tests 111/116 completed. (0 skipped) (55 failed)